[ 
http://issues.apache.org/jira/browse/MYFACES-1118?page=comments#action_12366416 
] 

Sylvain Vieujot commented on MYFACES-1118:
------------------------------------------

I didn't really follow the last modifications with the resourceLoaders, but the 
parsed lastModified is used in 
org.apache.myfaces.renderkit.html.util.MyFacesResourceLoader.getLastModified()

And in my app, I still get this message :
Feb 15, 2006 4:18:01 AM 
org.apache.myfaces.renderkit.html.util.MyFacesResourceLoader getLastModified
SEVERE: Unparsable lastModified : @lastModified@

There are some good reasons to use a value that reflect the library last 
changed date instead of some timestamp renewed at every webapp start.
It's way more efficient, as the delay between 2 library's changes is always 
longer that the delay between 2 webapp restarts.
Also, if your webapp is hosted on several servers, with the library's last 
modified, you have always a constant valu accross your servers. With a webapp 
start time timestamp, you may have some inconsistencies between your servers.

So this property file isn't obsolete and we should keep it.

I see one problem though. It is that his was formerly in tomahawk, and it's now 
in common, So strictly speaking, the lastModified time of common might differ 
from the one of tomahawk (even if they are almost alway built together).

> DefaultAddResource cache disabled because of the Maven build
> ------------------------------------------------------------
>
>          Key: MYFACES-1118
>          URL: http://issues.apache.org/jira/browse/MYFACES-1118
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: Nightly
>     Reporter: Sylvain Vieujot

>
> Since the build is done by Maven, the ant code that was parsing the 
> commons/src/main/resources/org/apache/myfaces/renderkit/html/util/AddResource.properties
> by replacing the @lastModified@ tag with the build date is gone.
> So the file in the jar now contains 
> [EMAIL PROTECTED]@
> instead of something like :
> lastModified=2006-02-14 23:47:48 +0400
> The effect of this is that the resource files aren't cached anymore.
> I'm still very new to maven, so I don't know yet how to restore this in the 
> maven build.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to