MyFaces is its own project. There are general guidelines and principals that we follow but there are not many hard and fast rules other then "the community gets to decide." So if the community wants to use "_" or whatever else it is that is upsetting you, then that is how it will be. It doesn't matter what Sun or anyone else says.
Since you are a valuable contributing member of the community, you get to help us make that decision. If you are proposing Sun's style, that is fine but we don't have to accept it just because Sun likes it. True, it is a known standard but its not the only way of doing things. The key to MyFaces being a successful project is being flexible. Everyone needs to compromise. So you can't be disappointed everytime things do not turn out the way you want. Sometimes people will see it your way. Sometimes they will not. If you are open minded about things and learn to live with compromises you will have more fun on this project. (By the way, I have changed my mind on one of our earlier disagreements and now agree with you - more on that in another thread.) I *personally* do not like the '_' style. I do not use it in my code and I've never worked on a java project (until this one) that has. That does not stop me from just following the informal standard that exists now and use it (when I remember to.) Lets all agree that in the end its more important that there be a standard rather then what that standard is. I'm ok with whatever you guys come up with (including the Sun style) but I won't be spending any time volunteering to refactor things for code style since I can easily live with what we have. Sean On 2/18/06, Bernd Bohmann <[EMAIL PROTECTED]> wrote: > My real question is: > If everybody is unhappy with the codestyle of MyFaces, why we don't > change the code. > We should define a codestyle > My proposal is this: > > http://svn.apache.org/repos/asf/myfaces/maven/trunk/build-tools/src/main/resources/org/apache/myfaces/checkstyle.xml > > It should be the sun codestyle with some extra checks. > > I will help to change the code in MyFaces. I'm not able to change all > the code but I'm able to change the code in one or two subprojects of > myfaces. > > I'm disappointed about statements like: > MyFaces is going a different way. > > I will go the Apache way but sometimes I don't understand the MyFaces way. > > Martin Marinschek schrieb: > > I'm having a good laugh here ;) > > > > It's interesting how long we can keep ourselves busy with something like > > that. > > > > For the interested - a short history of the "_" in MyFaces: > > > > MyFaces was originally started as a project for an inhouse-application > > of the OeKB (http://www.oekb.at), and the OeKB has this internal > > code-style rules which prescribe an "_" in front of private fields > > (yes, exactly for the VI-editor users under the OeKB developers, yes, > > there are still some ;). Now when the project went to SourceForge, no > > one did take the time to change this, and when we went further to the > > ASF, no one thought about that as well. > > > > So this is why we have this _ in place right now - as my most > > preferred IDE (IntelliJ) copes with this real well (you change a > > setting, and you have _ support in place), this is not a religious > > thing for me. > > > > I don't have a problem if someone goes through all the code and does a > > clean-up - but do we really want to do that? > > > > Bernd - even though you're disappointed - would you really take the > > time to clean that up? > > > > Wouldn't be too easy, right? > > > > regards, > > > > Martin > > > > On 2/18/06, Bernd Bohmann <[EMAIL PROTECTED]> wrote: > > > >>Why we should stick with the '_'? > >> > >>The Apache Code Style is the Sun Code Style without allowing tabs. > >>MyFaces is the first project that used the '_'. (so far I can see) > >>The Sun Code Style doesn't allow the '_'. > >> > >>And I would never accept code without braces. > >> > >>Sean Schofield schrieb: > >> > >>>Since most of the code in myfaces right now also uses the '_' I think > >>>we should stick with it. > >>> > >>>Everyone needs to keep in mind that the final code style that we come > >>>up with is not going to be the same as your personal preference or > >>>what Sun says is the "right way." There is an overall style to *most* > >>>of the code and we need to stick with what we started. > >> > >>XXXXXXXXXX > >> > >>Why should the code style doesn't fit with my personal preferences and > >>what is wrong with the Sun way? > >>Why we need stick? Are you using vi? > >> > >> > >> > >>>So lets document the standards and make sure everything from this > >>>point on conforms to those standards. Ideally the standards won't > >>>differ much from what we already have. > >>> > >> > >>The current MyFaces codestyle is very ugly. > >> > >> > >>>Again, the "_" is not my personal favorite but it is the standard and > >>>it has the added bonus of matching up with the ADF stuff. So lets > >>>stick with it. > >> > >>What is about the tobago stuff? Have you ever looked at the tobago code? > >>You don't like the tobago code style? > >> > >>>Sean > >>> > >> > >>I'm very disappointed > >> > >>Bernd > >> > > > > > > > > -- > > > > http://www.irian.at > > > > Your JSF powerhouse - > > JSF Consulting, Development and > > Courses in English and German > > > > Professional Support for Apache MyFaces > > > > -- > Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development > Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com > phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333 >
