Manfred,

I see you have made progress on the refactor.  So far I have only
looked at shared.  I made a minor change which was to change the
version to 2.0.0-SNAPSHOT.  This is to differentiate it from the
earlier failed 1.1.x commons versions.  I also feel that it will be
less confusing if the shared stuff is 2.0.x while the core and
tomahawk are 1.1.x.

Make sense?

Sean

ps. I'm going to take a look at the reset of the refactored stuff now.



On 2/24/06, Manfred Geiler <[EMAIL PROTECTED]> wrote:
> Ok, this problem can be easily done in IDEA by not renaming or moving
> the packages themself but by just moving the commons classes into
> their new location (ie packages). This way SVN history is ok, and core
> and tomahawk get adjusted automatically.
>
> Sean, just to be sure I fully understand your plan:
> We do the refactoring only on the (new) 1_1_2 branches, right?
>
> Since I'm still a SVN newbie:
> I can achieve this by manually checking out:
>  commons  (branch "1_1_2")
>  core   (branch "1_1_2")
>  maven (trunk)
>  site (not needed)
>  tomahawk  (branch "1_1_2")
>  pom.xml (from "current" trunk)
>
> With mvn idea:idea I should get a working IDE environment where I can
> do the refactoring.
>
> What about commons  branch 1_1_2? Is that a new one or still the one
> that was created during the recent release?
>
> As soon as we have a synchronized plan I can start up.
>
> Manfred
>
>
>
>
> On 2/23/06, Sean Schofield <[EMAIL PROTECTED]> wrote:
> > Well I'm new to idea so I did not have time to experiment.  It still
> > seems like that would be a problem because we want the tomahawk and
> > core classes to be refactoring to use the new package.  We just don't
> > want their classes in the same dirs to move.
> >
> > Sean
> >
> > On 2/23/06, Volker Weber <[EMAIL PROTECTED]> wrote:
> > > Hi,
> > >
> > > On 19:53 Sean Schofield wrote:
> > > > The refactoring will be a pain because both JBuilder and Idea want to
> > > > rename the package in all of the modules and not just commons.
> > >
> > > after running 'mvn idea:idea' there should be a commons only project
> > > file 'myfaces-commons.ipr' in the commons dir.
> > > IMO this should useable to refactor only commons.
> > >
> > > Regards,
> > >   Volker
> > >
> > > --
> > > Don't answer to From: address!
> > > Mail to this account are droped if not recieved via mailinglist.
> > > To contact me direct create the mail address by
> > > concatenating my forename to my senders domain.
> > >
> >
>

Reply via email to