> -----Original Message----- > From: Mike Kienenberger [mailto:[EMAIL PROTECTED] > Sent: Friday, February 24, 2006 5:28 PM > To: MyFaces Development > Subject: Re: [jira] Created: (MYFACES-1153) PortletUtil should not be > marked as @deprecated > > What about providing an RI-compatible version of PortletUtil as well, > and using reflection (or some other trick) to determine which code to > use? Then we could put it back into myfaces-commons.
Good thought Mike. It was originally implemented that way. However, that required a dependency on the portlet API, which may not be present in servlet-based apps. MyFaces core will continue to need the PortletUtil for this reason and because this code is executed with each request and is faster than reflection. Now that I think about it, what probably happened was that this got moved to commons, deprecated, and moved back to impl. Whoever moved it back to impl probably just forgot to remove the @deprecated message. Right now, there is no fool-proof implementation-independent way to tell if you are running as a portlet. Maybe we can fix this in JSF 2.0. Stan > > On 2/24/06, Stan Silvert (JIRA) <[email protected]> wrote: > > PortletUtil should not be marked as @deprecated > > ----------------------------------------------- > > > > Key: MYFACES-1153 > > URL: http://issues.apache.org/jira/browse/MYFACES-1153 > > Project: MyFaces Core > > Type: Improvement > > Components: General > > Versions: 1.1.2-SNAPSHOT > > Environment: all > > Reporter: Stan Silvert > > Assigned to: Stan Silvert > > Priority: Minor > > Fix For: 1.1.2 > > > > > > The org.apache.myfaces.portlet.PortletUtil class has been marked as > deprecated with the following message: > > > > @deprecated These utils work only with the MyFaces implementation and > therefore should be moved to myfaces-impl in the future > > > > I was unable to find a related Jira task on this, so I don't know how it > got there. It is true that this class is meant to only work with MyFaces, > but it already lives in impl. So, I don't understand why this has been > marked deprecated. It certainly isn't deprecated as in, "App developers > shouldn't use this". PortletUtil actually gives portlet developers some > flexibility that is not found in the RI. > > > > Maybe whoever put this there thought it was part of API? > > > > Anyway, if there are no objections, I will remove the @deprecated > message soon. > > > > -- > > This message is automatically generated by JIRA. > > - > > If you think it was sent incorrectly contact one of the administrators: > > http://issues.apache.org/jira/secure/Administrators.jspa > > - > > For more information on JIRA, see: > > http://www.atlassian.com/software/jira > > > >
