[ http://issues.apache.org/jira/browse/MYFACES-434?page=comments#action_12370574 ]
Dave Brondsema commented on MYFACES-434: ---------------------------------------- As far as an evaluation of the code, I think it's fairly good. Unfortunately even though the tomahawk filter does not have a true dependency on myfaces-impl, in all practicality it does. impl's PortletFilterWrapper expects TomahawkPortletFilter to have specific methods. And TomahawkPortletFilter is only going to be able to work if you have MyFacesFilterPortlet from myfaces-impl. But I think that unfortunately is an unavoidable design issue because the portlet spec doesn't define filters, so we have to implement them. There's probably no way we could write a tomahawk file upload component (for portlets) that works in all JSF implementations because we need a portlet filter and there's no standard way to do that. Perhaps we could move the MyFacesFilterPortlet into tomahawk for the purposes of the tomahawk file upload component. But it really needs to be in the implementation if it is to be able to work with the AddResource class. > MyFaces's Portlet enhancement > ----------------------------- > > Key: MYFACES-434 > URL: http://issues.apache.org/jira/browse/MYFACES-434 > Project: MyFaces Core > Type: Improvement > Versions: 1.1.0 > Environment: LInux, J2SE 1.4.2 > Reporter: Shinsuke SUGAYA > Assignee: Stan Silvert > Attachments: filter051230.patch, filter051230.tar.gz, filterportlet.patch, > filterportlet.tar.gz, headerresource_for_j2.tar.gz, > impl-filter-noAddResources-060315.patch, newfile_for_portlet.tar.gz, > patch_for_portlet.patch, tomahawk-filter-noAddResources-060315.patch > > MyFacesGenericPortlet does not fully support the feature of tomahawk > component, such as inputHtml and fileUpload. So, I request the following > feature to run it on portlet: > - support tags in <head> (ex. inputHtml component) > - support upload (fileUpload component) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
