[
http://issues.apache.org/jira/browse/MYFACES-1259?page=comments#action_12374065
]
Chad Lyon commented on MYFACES-1259:
------------------------------------
You must turn on your extensions filter now in order for the getScrolling()
function to get appended. Add the following to your deployment descriptor:
<filter>
<filter-name>
MyFacesExtensionsFilter
</filter-name>
<filter-class>
org.apache.myfaces.component.html.util.ExtensionsFilter
</filter-class>
<init-param>
<param-name>maxFileSize</param-name>
<param-value>20m</param-value>
<description>Set the size limit for uploaded files.
Format: 10 - 10 bytes
10k - 10 KB
10m - 10 MB
1g - 1 GB
</description>
</init-param>
</filter>
<filter-mapping>
<filter-name>MyFacesExtensionsFilter</filter-name>
<servlet-name>Faces Servlet</servlet-name> </filter-mapping>
<filter-mapping>
<filter-name>MyFacesExtensionsFilter</filter-name>
<url-pattern>/faces/myFacesExtensionResource/*</url-pattern>
</filter-mapping>
If seems the extensions filter is now appending that javascript function
instead of the Faces Servlet as in 1.1.1. If this is the desired functionality
then the Faces Servlet should not be adding the call to the function to the
controls' onclick javascript events. It should be left up to the extensions
filter which means that only the myfaces extended controls can utilize the
auto-scrolling functionality.
It seems to me like someone needs to decide which the desired functionality is:
1. The use of regular (non-extended) commandLink and commandButton controls can
take advantage of the auto-scroll feature. (therefore put auto-scroll back in
the core and let the Faces Servlet handle this)
2. Only Myfaces extended commnadLink and commandButton controls can take
advantage of the auto-scroll feature (move all auto-scrolling javascript
generation to the extensions filter). It looks like someone did a partial move.
> login page commandLink error
> ----------------------------
>
> Key: MYFACES-1259
> URL: http://issues.apache.org/jira/browse/MYFACES-1259
> Project: MyFaces Core
> Type: Bug
> Versions: 1.1.2-SNAPSHOT
> Environment: JBoss 4.0.4 RC1, MyFaces 4/4/06 night build.
> Reporter: Dave
> Priority: Blocker
>
> Upgraded to JBoss 4.0.4RC1 and MyFaces 4/4/06 night build.
> When user visit a protected page, the login.jsp will show up for user to
> login in.
> But in the login.jsp, if clicking commandLink "Forget Password", "Error on
> Page" will show up on browser status bar (IE).
> nothing else happens. It was working before: JBoss 4.0.3 RC1 and MyFaces
> 1/16/06.
> login.jsp (simplified for testing)
> -----------
> <%@ page contentType="text/html; charset=UTF-8"%>
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h" %>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f" %>
> <HTML>
> <body>
> <f:view>
> <h:commandLink value="Forget Password"
> action="#{bean.resetPassword}"/>
> </f:view>
> </body>
> </html>
> Browser source
> ------------------
> <HTML>
> <body>
> <a href="#"
> onclick="clear_linkDummyForm();document.forms['linkDummyForm'].elements['autoScroll'].value=getScrolling();document.forms['linkDummyForm'].elements['linkDummyForm:_link_hidden_'].value='_idJsp0';if(document.forms['linkDummyForm'].onsubmit){var
> result=document.forms['linkDummyForm'].onsubmit(); if( (typeof result ==
> 'undefined') || result )
> {document.forms['linkDummyForm'].submit();}}else{document.forms['linkDummyForm'].submit();}return
> false;" id="_idJsp0">ForgetPassword</a>
>
> </body>
> </html>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira