L.S.,
Yesterday I attached a patch to issue TOMAHAWK-36 in JIRA, but
apparently JIRA doesn't send notifications when you attach a file, so
I'll just repeat the question in the comment of this issue here directly.
The patch file contains modification to make <s:fieldset/> render it's
own children and to make <t:panelGroup/> support the JSF 1.2 layout
atttribute (layout="block").
The solutions works for me, but I'm still puzzled by the comment
//------------------ GENERATED CODE BEGIN (do not modify!)
--------------------
in HtmlPanelGroup. I do not see any code generation happening, so I just
manually edited this block to solve my problem. If I missed something
here, just let me know and I'll take the necessary steps to 'do it
right' and change the code generator's input file accordingly (whatever
it might be).
The code generation for common component methods is currently out of order. Sorry.
It was once used to generate all those boring getters, setters, state saving stuff and the like from the according "<classname>.xml" file.
So, modifying code between those hint banners is not the best thing to do, but the only thing that is possible right now. Unfortunately. I hope that I can find the time to make code generation work again in the near future.
Two things you might consider:
1. Mark the modification with a comment "//--- MANUALLY MODIFIED CODE BEGIN ---" and "...END..."
2. Supplement the modification in the according xml file (if possible)
My second question: Am I following the correct 'procedure' by simply
attaching patches to JIRA issues or should I have taken another approach
to get this issue solved?
Yes, that's perfect.
Thanks,
Manfred
Regards,
Gert Vanthienen
