So DummyFormUtils has to move from tomahawk to shared or at least two components will not work in the release ?
:( Dennis Byrne >-----Original Message----- >From: Martin Marinschek [mailto:[EMAIL PROTECTED] >Sent: Monday, April 17, 2006 03:13 PM >To: 'MyFaces Development' >Subject: Re: JIRA Issues TOMAHAWK-245 and 246 > >+1 for the change. > >regards, > >Martin > >On 4/17/06, Dennis Byrne <[EMAIL PROTECTED]> wrote: >> Hello Sharath, >> >> Thanks for taking a look at these two, I didn't know they were related. >> Your just in time for the new tomahawk release ;) I won't be able to take a >> look at this until the end of the week but it would really help us out if >> you put a patch in JIRA. >> >> Dennis Byrne >> >> >-----Original Message----- >> >From: sharath reddy [mailto:[EMAIL PROTECTED] >> >Sent: Monday, April 17, 2006 08:19 AM >> >To: [email protected] >> >Subject: JIRA Issues TOMAHAWK-245 and 246 >> > >> > >> >The issues pertain to exceptions while accessing the >> >Simple examples for Tree and PanelStack. >> > >> >Both these issues are related to the Tree component >> >(the older one). >> > >> >HtmlTreeImageCommandLinKRenderer extends >> >HtmlLinkRendererBase, and calls the method >> >'super.renderCommandLinkStart', which in turn >> >internally calls 'renderJavaScriptAnchorStart'. >> > >> >The code in this method is as follows: >> >FormInfo formInfo = findNestingForm(component, >> >facesContext); >> >if (formInfo == null) >> >{ >> > throw new IllegalArgumentException("Component " + >> >clientId + " must be embedded in an form"); >> >} >> > >> >This is the exception that shows up in the stack >> >trace. >> > >> >The issues can be fixed simply, by replacing: >> > >> >FormInfo formInfo = findNestingForm(component, >> >facesContext); >> > >> >with: >> > >> >FormInfo formInfo = >> >DummyFormUtils.findNestingForm(component, >> >facesContext); >> > >> >The difference is that if the second method fails to >> >find an enclosing form, it sets a parameter informing >> >MyFaces to render the dummy form, and returns the >> >dummy form information. Many Tomahawk components >> >already do this check and set the necessary parameter. >> > >> > >> >HOWEVER: >> >The same method is also used by the core components >> >(HtmlCommandLink, etc) and I am assuming that they >> >should have no knowledge of the MyFaces dummy form. >> > >> >So is it OK to go ahead with this change, or is there >> >a better solution? >> > >> >Regards, >> >Sharath >> > >> >__________________________________________________ >> >Do You Yahoo!? >> >Tired of spam? Yahoo! Mail has the best spam protection around >> >http://mail.yahoo.com >> > >> >> >> > > >-- > >http://www.irian.at > >Your JSF powerhouse - >JSF Consulting, Development and >Courses in English and German > >Professional Support for Apache MyFaces >
