[ 
http://issues.apache.org/jira/browse/MYFACES-1289?page=comments#action_12375399 
] 

Adam Winer commented on MYFACES-1289:
-------------------------------------

Patch:

Index: 
core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java
===================================================================
--- 
core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java
    (revision 394022)
+++ 
core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java
    (working copy)
@@ -254,7 +254,9 @@
         if (isDisabled(facesContext, uiComponent)) {
             writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
         }
-        writer.writeText("", null); // close input
+
+        writer.endElement(HTML.INPUT_ELEM);
+
         if ((label != null) && (label.length() > 0)) {
             writer.write(HTML.NBSP_ENTITY);
             writer.writeText(label, null);


> selectBooleanCheckbox does not call endElement("input")
> -------------------------------------------------------
>
>          Key: MYFACES-1289
>          URL: http://issues.apache.org/jira/browse/MYFACES-1289
>      Project: MyFaces Core
>         Type: Bug

>   Components: JSR-127
>     Versions: 1.1.2
>     Reporter: Adam Winer

>
> HtmlCheckboxRendererBase.renderCheckbox() uses writeText("") to try to close 
> up the input;  that's incorrect.  It should use endElement("input").  This 
> bug generates a bunch of warnings when using MyFaces with ADF Faces, and also 
> will generate invalid XHTML.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to