[ http://issues.apache.org/jira/browse/TOMAHAWK-437?page=comments#action_12416671 ]
sean schofield commented on TOMAHAWK-437: ----------------------------------------- There seem to be a few problems here. 1.) Cookies should not be created if preserveToggle == false. Right now the client side toggle javascript creates them regardless. 2.) Cookies should not be processed during ApplyRequestValues if preserveToggle == false. Decode() method should add a check for this (as you are suggesting.) 3.) Cookies should not be read by HtmlTreeRenderer during encodeBegin() as they are now. The call from decode() should be sufficient. > Tree2 uses cookies when preserveToggle==false > --------------------------------------------- > > Key: TOMAHAWK-437 > URL: http://issues.apache.org/jira/browse/TOMAHAWK-437 > Project: MyFaces Tomahawk > Type: Bug > Components: Tree2 > Versions: 1.1.2 > Environment: actually the release version is 1.1.3 > Reporter: Chris Hane > Priority: Minor > > This should probably be two issues, but I will let you decide that. > 1. Can not have same screen open in two windows. Cookies from one screen > affect the toggle status of the tree in the secon window. > 2. preserveToggle==false still sets a cookie... > Here is the original email to the list > http://marc.theaimsgroup.com/?l=myfaces-dev&m=114727809302352&w=2: > <paste> > I have been playing around with the tree2 control trying to make it do what I > want. Nice control.... > Question, I have been having issues with the following setup: > - clientSideToggle = true > - preserveToggle = false > When I have two windows open on the same view, the tree2 state is shared > between both. This means that someone can not view two different records and > have different tree expand/collapse states. Or more specifically, when I > execute an action (commandLink) on the tree and return the same view (i.e., > add/delete a TreeNode), the state of expanded/collpased nodes is read from > the cookie. > I think I traced it down to the HtmlTreeRenderer.decode method. > At line 123 is: > if(tree.isClientSideToggle()) > { > restoreStateFromCookies(context, component); > } > Shouldn't the if statement also look at the tree.isPreserveToggle()? Not an > expert in JSF by any stretch of the imagination, so if I'm on the wrong track > or this doesn't make sense just let me know.... > Chris.... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
