[ http://issues.apache.org/jira/browse/MYFACES-1353?page=comments#action_12419299 ]
Adam Winer commented on MYFACES-1353: ------------------------------------- This seems invalid to me; Seam shouldn't be using text/html to send RSS feeds. A RenderKit is responsible for vending a ResponseWriter for its content. It'd be a great feature if MyFaces Core vended a straight XML ResponseWriter - no special HTML rules - for content types like text/xml and application/rss+xml. I can donate the code for that ResponseWriter. > HtmlResponseWriterImpl - Prematurely Closes HTML Elements > --------------------------------------------------------- > > Key: MYFACES-1353 > URL: http://issues.apache.org/jira/browse/MYFACES-1353 > Project: MyFaces Core > Type: Bug > Components: General > Versions: 1.1.5-SNAPSHOT > Environment: Facelets, JBoss Seam > Reporter: Jacob Hookom > Priority: Blocker > > http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlResponseWriterImpl.java?view=markup > Sometimes ResponseWriters are used to supplement other markups and in JBoss > Seam's Blog example, we provide RSS feeds: > he following facelets template: > >> > >> <link>foo</link> > >> > >> generates: > >> > >> <link/>foo > This is driven by the static set 's_emptyHtmlElements' where the > closeIfNecessary() closes elements before they have a chance to be closed by > the user of the ResponseWriter. The logic should be if the endElement is > written and there's no body, then use that specialized set to determine if > the element should be written as closed or not. > I'm not sure if the logic was setup to correct issues with errant Renderers, > but correcting HTML markup should only be handling cases where a closed > element will not work (span, div, script, etc)--- not the other way around. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
