Yes, finally I used that approach (don't add the FacesContext
attribute and get it with the static method) in RenderUtils, in
HtmlJSCookMenuRenderer and in SubFormRenderer.

I'm doing some test (thought more testing will be required), then I'll
upload the new patch in JIRA.

Ciao
Cosma

2006/7/6, Mario Ivankovits <[EMAIL PROTECTED]>:
Hi Cosma!
> About RenderUtils I'm in doubt.. I changed the return type and added
> the FacesContex argument, so its really a "new" method, I think that
> it is useless to mark it as deprecated.. also because it actually does
> a thin wrapping for the _ComponentUtils method, as it extracts the
> UIComponent from the FormInfo object.
Why did you add the FacesContext argument? You can get it throug
getCurrentInstance() too.
However, shared is not that important for me as we always release it as
a copy within the released artifact itself.
If someone outside of tomahawk use shared he/she might have problems,
though, this method might not be that widely used.

>
> I'm for leaving it without deprecation.. note that the original method
> is actually gone :)
Ok.


Ciao,
Mario


Reply via email to