Mike, I think abit has been already done, I remember when martin asked me about family for adf/trinidad.
-Matthias On 8/16/06, Mike Kienenberger <[EMAIL PROTECTED]> wrote:
If it were trivially-obvious to me, I'd have done it already. I don't want to take the time to research how it's been done in the past -- my thoughts were that it would be easy for you since you've done it before. So my preference would be your todo list :-) On 8/16/06, Martin Marinschek <[EMAIL PROTECTED]> wrote: > Yes, I should. > > I've been changing over every "instanceof UIForm" to some utility > method where I check for the component family being either > javax.faces.form or the ADF faces equivalent. This occurrence I > overlooked, and it needs to be changed as well. > > I know you're cleaning up currently - can you fix that while cleaning? > If not, I'll put it under my todo's right now... > > regards, > > Martin > > On 8/16/06, Mike Kienenberger <[EMAIL PROTECTED]> wrote: > > Hey Martin, now that you're back :--) > > > > Shouldn't you be checking against a Form Family member rather than a > > UIForm? I know ADFFaces/Trinidad doesn't descend from UIForm. > > > > > > On 7/4/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > Author: mmarinschek > > > Date: Tue Jul 4 13:41:53 2006 > > > New Revision: 419092 > > > > > > URL: http://svn.apache.org/viewvc?rev=419092&view=rev > > > Log: > > > implemented a check for nested forms. Nested forms are not allowed in HTML - and if you do use them, they cause unpredictable behaviour, depending on the browser family. > > > > org.apache.myfaces.shared.renderkit.RendererUtils.checkParamValidity(facesContext, > > component, UIForm.class); > > > + if(parent instanceof UIForm) > > > + { > > > + throw new FacesException("You should never nest HTML-forms. "+ > > > + "This leads to unpredictable behaviour in all major browsers. "+ > > > + "You can use multiple forms on a page, but they may not be nested!"); > > > + } > > > > > UIForm htmlForm = (UIForm)component;
-- Matthias Wessendorf further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
