[ 
http://issues.apache.org/jira/browse/TOMAHAWK-596?page=comments#action_12428689 
] 
            
Mike Kienenberger commented on TOMAHAWK-596:
--------------------------------------------

This only renders the children of a facet.
It doesn't render the non-facet children of datascroller.

I haven't tested it (since I haven't installed your patch), but I'd guess it'd 
break this kind of DataScroller usage:

                                <t:dataScroller id="scroll_information"
                                                for="searchResultsDataTable"
                                                rowsCountVar="rowsCount"
                                                
displayedRowsCountVar="displayedRowsCountVar"
                                                firstRowIndexVar="firstRowIndex"
                                                lastRowIndexVar="lastRowIndex"
                                                pageCountVar="pageCount"
                                                pageIndexVar="pageIndex"
                                                >
                                        <h:panelGrid
                                                columns="1">
                                                <h:outputFormat value="{0} 
records found, displaying {1} records, from {2} to {3}. Page {4} / {5}" 
styleClass="standard" >
                                                        <f:param 
value="#{rowsCount}" />
                                                        <f:param 
value="#{displayedRowsCountVar}" />
                                                        <f:param 
value="#{firstRowIndex}" />
                                                        <f:param 
value="#{lastRowIndex}" />
                                                        <f:param 
value="#{pageIndex}" />
                                                        <f:param 
value="#{pageCount}" />
                                                </h:outputFormat>
                                        </h:panelGrid>
                                </t:dataScroller>

Also, I don't have access to a portlet environment to test this.  Sorry about 
that, but I can only master so many technologies at once :-)

> Duplicate id exception for HtmlDataScrollerRenderer
> ---------------------------------------------------
>
>                 Key: TOMAHAWK-596
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-596
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.3
>         Environment: Linux, Windows
>            Reporter: Ryan Wynn
>         Attachments: HtmlDataScrollerRenderer.patch
>
>
> In a portlet environment a non-faces request produces an exception when the 
> faces tree is rendered if the faces tree contains a DataScroller component.  
> The HtmlDataScroller renderer actually renders its children twice in this 
> case, once in the encodeChildren method and once in the encodeEnd method.  
> Since rendering of the children is taken care of in encodeEnd I made the 
> encodeChildren method a no-op.  Also, although the  CommandLinks which are 
> rendered as children are marked as transient, they see to stick around.  I 
> put a check in the getLink methods to make sure that the links are not added 
> twice.  This seems to fix the duplicate id exception, but it might be 
> necessary to further investigate why they are sticking around in the first 
> place.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to