Hey Mario,

I hadn't noticed this before -- You added it while I was on vacation.
Sneaky.   :-)  And after you'd already +1'd my implementation in the
"currencyConverter -> BigDecimal storage" thread.

Yes, this would also work.   I've been using my own converter since
the start of May now.   How well tested is yours?

Some other comments:

- Mine inherits from NumberConverter.   Why didn't you do the same for
yours?  It looks like you instead copied that code into your
converter.

- Mine "fixes" the currency conversion issue by adding a currency
symbol (if it's a currency converter) to the value before parsing the
number.   We could merge this change into yours as well.

=================================================================


  [ 
http://issues.apache.org/jira/browse/TOMAHAWK-610?page=comments#action_12429107
]

Mario Ivankovits commented on TOMAHAWK-610:
-------------------------------------------

In the sandbox there is a numberconverter which will automatically
detect the required destination type by looking at the value binding.
Might this not do the job too?

Reply via email to