[ 
http://issues.apache.org/jira/browse/TOMAHAWK-464?page=comments#action_12431161 
] 
            
Michael Lipp commented on TOMAHAWK-464:
---------------------------------------

I strongly support eliminating ExtensionsFilter. As Michael Binette has pointed 
out, there is a solution for adding style sheets. There is also a solution for 
handling file upload in the portlet bridge (as I have shown in MYFACES-556). 
Delivering resources from the MyFaces/Tomahawk jars can also simply be 
implemented by intercepting "special" URLs in the Servlet (or by a phase 
listener if you want), so this doesn't require a filter neither. (And honestly: 
isn't scanning and patching the generated HTML a very clumpsy approach?)

I like using MyFaces, especially I like the additional features of Tomahawk. 
But I think it is an error of the MyFaces team to neglect portlet support as 
they do. I do believe that portal based applications will become more and more 
important (well, I should, currently working on them ;-)).

I don't know what other issues ExtensionsFilter is trying to address, but I'd 
be happy to help with solving them, at least conceptually.

I'm afraid conceptional help is all I will be able to offer, because another 
flaw of the MyFaces project is maintaining the source code in the way it does. 
I spent three days' evenings trying to configure a source code tree that 
matches the 1.1.3 binary distribution for debugging a problem. The SVN tree is 
a total mess. E.g. what version of "shared" is associated with 1.1.3? The build 
system seems to have changed since 1.1.3. The 1.1.3-taged versions of core and 
tomahawk reference some file in maven ("I hate maven" (TM)) that does not 
exists. I'd really like to contribute patches but I can't reliably establish 
the reference.

I'll now endeavour to move (at least) the adding of JavaScript to the portlet 
bridge. If anybody is interested: I'm mainting my own version of such a bridge 
with a lot of bug fixes at 
http://wfmopen.cvs.sourceforge.net/wfmopen/wfmopen/src/de/danet/an/util/jsf/MyFacesAdaptedPortlet.java?view=markup.
 I'm positive that I'll have the JavaScript merging in there at the end of the 
week.

> Make Tomahawk work in portals
> -----------------------------
>
>                 Key: TOMAHAWK-464
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-464
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>          Components: ExtensionsFilter
>    Affects Versions: 1.1.1, 1.1.3-SNAPSHOT, 1.1.2, 1.1.4-SNAPSHOT
>            Reporter: Danijel Jevtic
>
> The ExtensionsFilter isn't working inside Jetspeed. Though this is not a 
> technical blocker it would be great to be able to create portlets with 
> tomahawk components (e.g. tree2). It works fine in 1.1.0 though.
> Kind regards

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to