I don't see it as being cleared up. The points that we need to have a new 1.1.4 branch, and that branch needs to include at least 3 blocker fixes still hasn't been addressed. If you make your changes now, we either have to accept them as part of the 1.1.4 branch, accept the blocker issues as part of the 1.1.4 release, or track patches for these issues separately in both branches in a temporally-disjoin manner.
On 9/15/06, Werner Punz <[EMAIL PROTECTED]> wrote:
Ah no worries, I didnt take it directed at me. I just wanted to clear things up. Ok lets sum things up from my side. Since there was no objection from anyone (now that the entire 1.1.4 situation is cleared up) I will start to go ahead with the push of the dojo core from the sandbox down into Tom in the trunk. Tomorrow I will open a jira issue and will mark all commits regarding this work with the references to the issue. Once this is done we can move on finally regarding a bunch of heavily used sandbox components. (which has been overdue way too long) Werner Mike Kienenberger schrieb: > Werner, sorry if you took the "sweeping" changes comment as directed > at you. I wouldn't expect the dojo code to impact many files. I > don't consider the addition of files as a change that has any impact. > I was thinking more of the proposed common jar changes (and other > changes in general that should be considered before we make a > release). > > > On 9/15/06, Werner Punz <[EMAIL PROTECTED]> wrote: >> Mike Kienenberger schrieb: >> > Ok. I've went through the Tomahawk issue tracker and looked at all >> > Blocker and Critical issues. I find three that appear to be >> > regressions (no patches), and one that appears to affect other >> > frameworks (includes a patch). >> > >> > Everything else I changed to major priority. >> > >> > But this did bring up another consideration. If we are going to make >> > wide, sweeping changes to Tomahawk, we need to commit all outstanding >> > patches first. Otherwise these patches are going to become obsolete. >> > >> > >> >> Just to clear things up, my move of dojo is not a wide sweeping >> change of tomahawk, it is more an additional codebase >> which is moved from the sandbox down to the core >> (if you think that the pure addition of code is a wide sweeping change >> then it is) >> >> I tried to take care that no core tomahawk code was touched from >> my side when I was working on the dojo stuff. >> I added my own tools class for dojo only so that I did not have >> to add it to the existing tools classes >> the rest is a lot of javascript resources and one component. >> >> I dont know what was done by the others, but that is mostly >> it of what I would start to migrate down. >> >> So no existing Tomahawk code will be altered only >> the example links will be touched, but a lot of code >> will be moved down from the sandbox to Tomahawk. >> (mostly with svn move) >> >> Expect a handful of java classes one component and several hundred >> javascript files being moved into Tom... >> >> >
