[ 
http://issues.apache.org/jira/browse/TOMAHAWK-668?page=comments#action_12436373 
] 
            
Martin Marinschek commented on TOMAHAWK-668:
--------------------------------------------

Well, yes - it doesn't really make sense to do anything with the written 
resource anymore. 

And if you'd want to change the response, you'd provide a wrapper around the 
response, and what you do there, is something entirely different.

regards,

Martin

> response stream closed in MyFacesResourceLoader.writeResource
> -------------------------------------------------------------
>
>                 Key: TOMAHAWK-668
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-668
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: ExtensionsFilter
>    Affects Versions: 1.1.3
>            Reporter: Mike Youngstrom
>         Assigned To: Martin Marinschek
>             Fix For: 1.1.4-SNAPSHOT
>
>         Attachments: patch.diff
>
>
> I was looking through the ExtensionsFilter code and noticed that 
> MyFacesResourceLoader.writeResource closes the response output stream.  Is 
> that desirable?  I also noticed that the resource input stream was not being 
> closed.  I've provided a small patch to change those two things.  If they 
> seem reasonable.
> Mike

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to