[ http://issues.apache.org/jira/browse/MYFACES-1418?page=all ]
Martin Marinschek updated MYFACES-1418:
---------------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Assignee: Martin Marinschek
Thanks to Nikolay Petrov for this fix.
I wonder - should the new base-class be prefixed by an underscore, to really
make sure that this is not part of the public API? It's already
package-private, so its ok to add it, but maybe we should have an additional
indicator here.
regards,
Martin
> javax.faces.validator - DoubleRangeValidator, LengthValidator,
> LongRangeValidator are very similar, refactor common behaviour
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: MYFACES-1418
> URL: http://issues.apache.org/jira/browse/MYFACES-1418
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-127
> Affects Versions: 1.1.4
> Reporter: Nikolay Petrov
> Assigned To: Martin Marinschek
> Fix For: 1.1.5-SNAPSHOT
>
> Attachments: validator.patch
>
>
> The 3 classes are very similar to each other except the type of minimum and
> maximum (and value of course). Therefore I'll suggest extracting the common
> behaviour in common parent class.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
