Hi Grant,

to my mind the patch will not work the proper way. If every time only
the content of the active panel tab is rendered out, values of the
others will be lost after the submit.

If we want this behaviour (e.g. a tab which does only output of
content) we should introduce a separate attribute which performs this
approach.

regards,

Gerald

On 9/26/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: grantsmith
Date: Tue Sep 26 11:56:50 2006
New Revision: 450145

URL: http://svn.apache.org/viewvc?view=rev&rev=450145
Log:
TOMAHAWK-701: patch applied

Modified:
    
myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/tabbedpane/HtmlTabbedPaneRenderer.java

Modified: 
myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/tabbedpane/HtmlTabbedPaneRenderer.java
URL: 
http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/tabbedpane/HtmlTabbedPaneRenderer.java?view=diff&rev=450145&r1=450144&r2=450145
==============================================================================
--- 
myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/tabbedpane/HtmlTabbedPaneRenderer.java
 (original)
+++ 
myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/tabbedpane/HtmlTabbedPaneRenderer.java
 Tue Sep 26 11:56:50 2006
@@ -542,7 +542,10 @@
                 if (tabIdx != selectedIndex) {
                     writer.writeAttribute(HTML.STYLE_ATTR, "display:none", 
null);
                 }
-                RendererUtils.renderChild(facesContext, child);
+                if (tabbedPane.isClientSide() || selectedIndex == tabIdx) {
+                  // render all content in client side mode or only the 
selected in server side mode
+                  RendererUtils.renderChild(facesContext, child);
+                }
                 writer.endElement(HTML.DIV_ELEM);

                 tabIdx++;





--
http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Reply via email to