On 11/20/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote:
What about moving getStringValue(Fcontext, VBinding) from _ComponentUtils to RendererUtils ?
I committed that change. If we really move the getStringValue() to RendererUtils that would mean classes like AliasBean or ValidatorBase are using RendererUtils. Which sounds to much like a util for a renderer developer :) But on the other hand the findNestingForm is much more related to renderers and if we move only that function away, we have a class with a single method. Also why is the name starting with "_" ? Thanks, Matthias
then I can *remove* that clazz, or at least set it as deprecated, since 3rd party can have dependency against it... On 11/20/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > fixed only once :) > > I saw that other find method, when looking at TabbedPane renderer :) > > On 11/20/06, Martin Marinschek <[EMAIL PROTECTED]> wrote: > > Sure not - I thought you had fixed that already a while ago - don't > > remember. We might need it once in the API and once in shared? Two > > times in shared is once too much. > > > > regards, > > > > Martin > > > > On 11/19/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > > but not in two methods :) > > > > > > On 11/19/06, Martin Marinschek <[EMAIL PROTECTED]> wrote: > > > > Hi Matze, > > > > > > > > we could do both an instanceof, and as a failsafe method, a family > > > > check as well. > > > > > > > > regards, > > > > > > > > Martin > > > > > > > > On 11/18/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > > > > one more on that. > > > > > > > > > > since we only use "families" the *second* method is not able to work > > > > > with the struts-faces bridge lib > > > > > > > > > > (since they provide a new form component (and family)) > > > > > > > > > > -M > > > > > > > > > > On 11/18/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > > > > > created issue and assigned to me: > > > > > > > > > > > > http://issues.apache.org/jira/browse/MYFACES-1496 > > > > > > > > > > > > I prefer to remove the method in the _Com...... clazz > > > > > > > > > > > > -M > > > > > > > > > > > > On 11/17/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > > > > > > is there a reason, why we have the findNestingForm method twice? > > > > > > > with the same logic. > > > > > > > > > > > > > > I'd like to refactor that, if there is no real reason. > > > > > > > > > > > > > > -M > > > > > > > > > > > > > > -- > > > > > > > Matthias Wessendorf > > > > > > > http://tinyurl.com/fmywh > > > > > > > > > > > > > > further stuff: > > > > > > > blog: http://jroller.com/page/mwessendorf > > > > > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Matthias Wessendorf > > > > > > http://tinyurl.com/fmywh > > > > > > > > > > > > further stuff: > > > > > > blog: http://jroller.com/page/mwessendorf > > > > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > > > > > > > > > > > > > > > -- > > > > > Matthias Wessendorf > > > > > http://tinyurl.com/fmywh > > > > > > > > > > further stuff: > > > > > blog: http://jroller.com/page/mwessendorf > > > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > > > > > > > > > > > -- > > > > > > > > http://www.irian.at > > > > > > > > Your JSF powerhouse - > > > > JSF Consulting, Development and > > > > Courses in English and German > > > > > > > > Professional Support for Apache MyFaces > > > > > > > > > > > > > -- > > > Matthias Wessendorf > > > http://tinyurl.com/fmywh > > > > > > further stuff: > > > blog: http://jroller.com/page/mwessendorf > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > > > -- > > > > http://www.irian.at > > > > Your JSF powerhouse - > > JSF Consulting, Development and > > Courses in English and German > > > > Professional Support for Apache MyFaces > > > > > -- > Matthias Wessendorf > http://tinyurl.com/fmywh > > further stuff: > blog: http://jroller.com/page/mwessendorf > mail: mwessendorf-at-gmail-dot-com > -- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
-- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
