Thanks for applying the patch. I integrated rev 509230 of myfaces/current12 into Geronimo's tomcat and jetty servlet containers. Now web apps deployed in Geronimo will be able to use MyFaces without including their own myfaces jars. See https://issues.apache.org/jira/browse/GERONIMO-2804 for details.
I'll keep you posted on how things progress, and would also like to start contributing patches if we encounter any problems in testing. Best wishes, Paul On 2/19/07, Mathias Brökelmann <[EMAIL PROTECTED]> wrote:
Hi Paul, I looked at you patch and found some other bugs around the resolvers which I'm going to check now. But for the meantime I will commit your patch to make the jsp stuff working. Cheers, Mathias 2007/2/19, Paul McMahan <[EMAIL PROTECTED]>: > Hey Matthias, I saw a couple of commits go through over the weekend > that looked related to the problem I am seeing with the resolvers in > the current12 branch. I wasn't sure if you are still planning to > apply the patch or if you preferred a different approach, but I wanted > to let you know that I am still seeing the NPE. You should be able to > recreate the error by adding a JSP like this to current12/test-webapp. > > <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %> > <% > java.util.ArrayList mylist = new java.util.ArrayList(); > mylist.add("one"); > pageContext.setAttribute("mylist", mylist); > %> > <c:forEach var="x" items="${mylist}"> > <p>${x}</p> > </c:forEach> > > > Best wishes, > Paul > > On 2/18/07, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > Hi Paul, > > > > ok, I'll apply your patch. and yes we have a tck@ list. Since you > > signed the NDA for Java EE, I guess you can subscribe easily to the > > myfaces list. > > > > -m > > > > On 2/18/07, Paul McMahan <[EMAIL PROTECTED]> wrote: > > > Hi Matthias, Thanks for taking a look at the patch. When I apply it > > > to my local copy of current12/core I am able to use JSF in a JSP > > > without breaking any JSTL apps. Without the patch JSPs that use JSTL > > > without also using JSF produce the NullPointerException mentioned > > > earlier. In that case org.apache.myfaces.application.ApplicationImpl > > > has created several resolvers that participate in JSTL's variable > > > resolution while assuming that the MyFaces context factory has already > > > put a FacesContext into the ELContext. > > > > > > Does the MyFaces project have a private list where details about TCK > > > are discussed that I could subscribe to? Alternatively I can provide > > > you with the address for Geronimo's TCK list that you can subscribe to > > > if you have signed the NDA. > > > > > > Best wishes, > > > Paul > > > > > > On 2/17/07, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > > > Paul, > > > > > > > > looks ok for me. What are the TCK tests saying ? > > > > Better now ? Also are the full JSF TCK tests part of the Java EE TCK ? > > > > > > > > -M > > > > > > > > On 2/16/07, Paul McMahan <[EMAIL PROTECTED]> wrote: > > > > > On 2/16/07, Paul McMahan <[EMAIL PROTECTED]> wrote: > > > > > > Question 2: > > > > > > After integrating MyFaces into Geronimo's Tomcat container (v6.0.8) I > > > > > > found that I could deploy JSF applications and pass many tests. > > > > > > However, I found that several of the JSTL tests no longer worked. It > > > > > > seems that when MyFaces has been enabled it assumes that all the JSPs > > > > > > in a web app will produce a FacesContext. But that's not the case for > > > > > > JSPs like the following: > > > > > [...] > > > > > > > > > > I created MYFACES-1536 for this and attached a patch to it that checks > > > > > for null after calling elContext.getContext(FacesContext.class). > > > > > Please commit if it looks ok or advise if it needs more work. > > > > > > > > > > Best wishes, > > > > > Paul > > > > > > > > > > > > > > > > > -- > > > > Matthias Wessendorf > > > > http://tinyurl.com/fmywh > > > > > > > > further stuff: > > > > blog: http://jroller.com/page/mwessendorf > > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > > > > > > > -- > > Matthias Wessendorf > > http://tinyurl.com/fmywh > > > > further stuff: > > blog: http://jroller.com/page/mwessendorf > > mail: mwessendorf-at-gmail-dot-com > > > -- Mathias
