El lun, 19-03-2007 a las 10:38 +0100, Zdeněk Sochor escribió: > Hi, > comments in-line. > > Josué Alcalde González napsal(a): > > >Hello. My name is Josué Alcalde and I am new to this list. > >I started four months ago to use myfaces in my projects and I would like > >to contribute, perhaps with new components. > > > > > Anyone is welcomed to contribute in apache projects ;) > > >I have read the wiki and now, I have a workspace for myfaces in eclipse. > > > > > > > Don't forget that MyFaces projects use Maven2 for building and Myfaces > 1.1 must be compiled under J2SE 1.4.
Don't worry. There is a good page in the wiki which explain all the process. Maven is good for build, but I can't life without Eclipse. :) > > >One thing I would like to have in myfaces is a clean way to render > >messages in differents divs for each level, to be able to have a box for > >every kind of messages. > > > >Now, the only workaround to do this is four t:messages and add a > ><Level>Style="display:none;" for the three unwanted messages but it will > >render the messages four times. > > > >I would like to make a patch adding four new boolean attributes: > >- fatalRendered > >- errorRendered > >- warnRendered > >- infoRendered > > > >It would be easy to do overwriting "renderSingleFacesMessage" and check > >the level there. > > > > > > > t:messages has already styleClasses attributes for each level of > importance (from JSF spec). > If you want to render each level messages together, add sorting > attribute for specifying order of rendering messages. > Rendering divs around each level of importance could be implemented as > another layout (t:messages has already support > for rendering as list or table). > I'm against using multiple t:messages tags in one page - hard to read > and it would save/restore the same messages in view. Yes, four t:messages is not a good idea. Perhaps a div layout would be a better approach, but there should be divInfoStyle and divInfoClass for the style, or the actual infoStyle and infoClass could be used for it. > > >I have been playing with it and I have some questions: > >- Is there a "Code Formatter Profile" for Apache Code coventions? > >- There is a code generation. I have been browsing the wiki and the > >lists and I haven't found how it works. There are some old messages > >which said it didn't work. > > > > > Code auto-generation was dropped in 1.1.1 release, i was playing with > making it work again, but > auto-generating won't be re-enabled in its former form. > MyFaces 1.2 uses new apt plugin for autogeneration from trinidad, so it > doesn't make sense > to support old and new forms. > > >Is it working now? If it works, how can I generate the new attributes? > >if it doesn't work, should I edit the tag definition, the tag class and > >the component class manually? > > > > > > > > > Manual editing is only way to altering components in MyFaces 1.1. > Submitting changes for contributers is done through JIRA issues and > providing unified diff patches. > Only PMC and commiters have direct wrtite access to svn repository, so > it's up to them if your patches are accepted. Thanks, I think I will develop a div Layout for t:messages. It could be usefull at least for me :) > > Regards, > Zdenek
