Abstract away the difference between field- and property-based injection
------------------------------------------------------------------------

                 Key: MYFACES-1619
                 URL: https://issues.apache.org/jira/browse/MYFACES-1619
             Project: MyFaces Core
          Issue Type: Improvement
    Affects Versions: 1.2.0-SNAPSHOT
            Reporter: Bernhard Huemer
            Priority: Trivial


Currently the implementation differs between field- and property-based 
injection both in processing annotations and in invoking the appropriate method 
to set the value being looked up. Needless to say, this approach causes great 
redundancy affecting even the latest revision [1]. Both methods should do 
similar annotation processing but the first one checks for the @Resource 
annotation twice (due to the delegation to the super class). Therefore I think 
you should abstract away the difference between field- and property-based 
injection.

[1]: 
http://svn.apache.org/viewvc/myfaces/core/branches/jsf12/impl/src/main/java/org/apache/myfaces/config/annotation/AllAnnotationLifecycleProvider.java?revision=518967&view=markup

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to