Looks fine by me. This code is purely for debugging, so efficiency isn't a big concern. However, we should probably consider switching to a HashSet.
-- Adam On 5/14/07, Matt Cooper <[EMAIL PROTECTED]> wrote:
Hi Jeanne, That is fine. It should cause no problems. If pretty-printing is used for purposes other than just debugging, we may want to consider how many elements are not listed. If that list is shorter, we ought to change this so we only compare against the shortest list of names. I believe we are approaching 50% but still under so no action needs to be taken yet. Thank you, Matt On 5/14/07, Jeanne Waldman <[EMAIL PROTECTED]> wrote: > Hi there, > > https://issues.apache.org/jira/browse/ADFFACES-489 > > I have a component, selectOneRadio, that renders the following HTML for > each radio button: > <span><input type='radio'/></span><label>My Label</label> > > The HTML pretty printer is inserting space after the input element, > causing extra space to be rendered between the input and the label. > > Added "input" to this list fixes the problem. Does anyone have a problem > with that? Could it cause a problem that I'm not aware of? > > return ("img".equals(name) || > "a".equals(name) || > "br".equals(name) || > "span".equals(name) || > "div".equals(name) || > "area".equals(name) || > "u".equals(name) || > "i".equals(name) || > "input".equals(name) || > "b".equals(name) || > "em".equals(name) || > "strong".equals(name) || > "map".equals(name) || > "label".equals(name) || > "font".equals(name) || > "table".equals(name) || > "tbody".equals(name) || > "tr".equals(name) || > "nobr".equals(name) || > "wbr".equals(name) || > "script".equals(name)); > > Thanks, > Jeanne >
