DataScoller - FastForward has borderline issues
-----------------------------------------------

                 Key: TOMAHAWK-1009
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1009
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Data Scroller
            Reporter: Lars Ködderitzsch


                
In certain cases the Fast forward works incorrectly, resulting in an empty 
table.
For instance you have 100 rows, 10 per page, fastforward set to 10.
You start off on the first page, then fast forward.

Due to a little bug in the page calculation, you will end up on page 11, which 
is empty.

Proposed fix:
snip from HtmlDataScroller broadcast -- see the line commented with //fix here

else if (FACET_FAST_FORWARD.equals(facet))
                {
                    int fastStep = getFastStep();
                    if (fastStep <= 0)
                        fastStep = 1;
                    int next = uiData.getFirst() + uiData.getRows() * fastStep;
                    int rowcount = uiData.getRowCount();
                    if (next >= rowcount) //fix here >= instead of >
                        next = (rowcount - 1) - ((rowcount - 1) % 
uiData.getRows());
                    setFirst(uiData, next);
                }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to