I've got no problem with someone building a component that has the same behavior as loadBundle. But changing loadBundle to be a component, in a patch release of 1.2 no less, is a BAD idea.
-- Adam On 6/1/07, Martin Marinschek <[EMAIL PROTECTED]> wrote:
Adam, look at this comment - there is a component for load-bundle now. regards, Martin This fix creates a transient UIComponent instance that wraps the Map that wraps the ResourceBundle for this tag instance, and places it in the UIComponent tree in the "right" place. When this special UIComponent's encodeBegin is called, it places the Map into request scope, as is normal for f:loadBundle. On 6/2/07, Martin Marinschek <[EMAIL PROTECTED]> wrote: > I didn't actually check the patch - I concluded from the comments that > Ed is somehow including a component in the tree. But this sounds > pretty bad... > > regards, > > Martin > > On 6/2/07, Adam Winer <[EMAIL PROTECTED]> wrote: > > I don't think it is in this patch. But for my taste, the > > fix here is far uglier than this minor bug. Adding a > > package-private method to UIComponentClassicTagBase > > and using Method.setAccessible(true)... <shudder>! Do we > > even know that container security permissions will uniformly > > allow this? > > > > -- Adam > > > > > > On 6/1/07, Martin Marinschek <[EMAIL PROTECTED]> wrote: > > > So you've finally decided to make loadBundle be a component. That's > > > good, that will help. Is it active in all lifecycle phases then? > > > > > > > > > regards, > > > > > > Martin > > > > > > On 6/1/07, rlubke <[EMAIL PROTECTED]> wrote: > > > > > > > > Hey guys, > > > > > > > > Just a heads up that a new backwards compatibility issue was found between > > > > 1.1 and 1.2. > > > > > > > > The details can be found here: > > > > https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=577 > > > > > > > > I'm guessing MyFaces will have the same issue if the attached reproduced > > > > application is > > > > run. If not, well, just ignore this ;) > > > > > > > > > > > > -- > > > > View this message in context: http://www.nabble.com/Heads-up---backwards-compatibility-found-between-1.1-and-1.2-tf3853363.html#a10916460 > > > > Sent from the My Faces - Dev mailing list archive at Nabble.com. > > > > > > > > > > > > > > > > > -- > > > > > > http://www.irian.at > > > > > > Your JSF powerhouse - > > > JSF Consulting, Development and > > > Courses in English and German > > > > > > Professional Support for Apache MyFaces > > > > > > > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces > -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
