CoreRenderer.renderStyleClasses() API non-obviously mutates the array
---------------------------------------------------------------------

                 Key: TRINIDAD-106
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-106
             Project: MyFaces Trinidad
          Issue Type: Improvement
          Components: Components
    Affects Versions: 1.0.1-core
            Reporter: Adam Winer
            Assignee: Adam Winer


The CoreRenderer.renderStyleClasses() API takes an array of style class 
strings.  In the
name of optimizing a StringBuilder that it assembles, it mutates this array.  
That's a highly
non-obvious design choice, and leads to some potentially very severe styling 
bugs when
a developer attempts to reuse an array.  We can do nearly as well on the 
optimization without
mutating the array at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to