I'd love to have an independent skinning module that all renderers can use.

We'll need a good plan on how we want to break this up and what APIs we have available for the renderers, what's public, what's private, how it works for pda, for portal, etc. We also need to put in place lots of tests so that we can ensure we don't break anything. Right now I do manual testing -- I run the app in a couple different skins and save the css file. Then before I check in I run the skins again and compare the css files. I do this in compressed and uncompressed modes. I'd love it if we have some automated tests so that we don't break skinning as we are refactoring it.

One feature I think we need is an API for the renderer to be able to 'map' a skin selector to something else -- like "af|foo::bar-link" could map to "af|foo::bar A". We don't want to expose af|foo::bar A as a public skin selector because it shows the implementation of the renderer. Right now we do this in FileSystemStyleCache, and that's obviously not a good way to do it. Anyway... that's on my list.

Cristi, I'm interested to see what you have done.

- Jeanne


Simon Lessard wrote:
Hello Cristi,

It would sure be nice to have an independent common skinning module for custom component libraries. However, I wonder what version of the skinning module you used and how you handled dependencies while refactoring it because there's many changes with skinning with every releases.


Regards,

~ Simon

On 7/30/07, *Cristi Toth* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>> wrote:

    Hi all!

    I just finished my diploma project on Skinning in MyFaces
    More exactly, what I did is refactoring out Trinidad's skinning
    feature into an independent module
    I also did a small and simple module that adds this feature to
    Tomahawk.
    It's very simple to use. It is intended to demonstrate how easy is
    to add skinning features to any component-set

    In the skinning module I tried to refactor and simplify the old
    Trinidad code behind.
    But there is some more work to do.

    So how do you think this would be usable to MyFaces?
    I mean what should I do now to get this code used and improved by
    the community?
    Wouldn't be nice to try to make Trinidad use this module and get
    rid of the skinning code from it?

    I'm waiting forward to your feedBack


    Best regards,
    Cristi Toth

    -------------
    Codebeat
www.codebeat.ro <http://www.codebeat.ro>

Reply via email to