[ 
https://issues.apache.org/jira/browse/MYFACES-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521849
 ] 

Ryan Lubke commented on MYFACES-1687:
-------------------------------------

The javadocs for UIInput.updateModel() states:

If the setValue() method call fails:

    * Enqueue an error message by calling addMessage() on the specified 
FacesContext instance.
    * Set the valid property of this UIInput to false.

Throwing an exception pretty much makes queuing moot.  

I've changed the RI to log the exception so that at least there is some useful 
information
about the failure somewhere.

That said, if you still feel that throwing an exception is preferred over the 
message behavior,
we can get Ed and Roger to weigh in to make a decision. 

> Update Model didn't throw an exception if an exception occurred, but adds a 
> message for display to the user 
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-1687
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1687
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-127, JSR-252
>    Affects Versions: 1.1.5,  1.2.0
>            Reporter: Martin Marinschek
>            Assignee: Martin Marinschek
>             Fix For:  1.1.6-SNAPSHOT, 1.2.1-SNAPSHOT
>
>
> According to all good sense, update model should throw an exception, and not 
> show a message in the message list, if setting the value of the model-bean 
> throws an exception itself. 
> Hopefully this won't make any problems with the TCK, if it does we should 
> challenge it.
> regards,
> Martin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to