eh, true. I focused mainly on the name and trinidadinternal --> trinidad changes, renderkit should indeed disappear.
On 8/28/07, Adam Winer <[EMAIL PROTECTED]> wrote: > > On 8/28/07, Danny Robinson <[EMAIL PROTECTED]> wrote: > > I agree on removing 'renderkit', I'd left it in there as you'd > originally > > defined the private version and I thought 'renderkit' was there for a > > reason. ;-) > > For private variables, because they proliferate so and aren't > centrally documented, I like to keep them disambiguated > by package. For public variables, the package-with-which-the- > functionality-is-associated is an implementation detail that > most shouldn't remember. (Trinidad isn't consistent on this > front though) > > -- Adam > > > > > > I'll make the change to make things simpler. > > > > D. > > > > On 8/28/07, Adam Winer <[EMAIL PROTECTED]> wrote: > > > On 8/28/07, Danny Robinson <[EMAIL PROTECTED]> wrote: > > > > Just wanted your comments/votes on the following web.xml settings > that > > we've > > > > previously agreed should be made public for 1.0.3: > > > > > > > > > > org.apache.myfaces.trinidadinternal.renderkit.USE_DIALOG_POPUP > > > > becomes > > > > > > org.apache.myfaces.trinidad.renderkit.ENABLE_LIGHTWEIGHT_DIALOGS > > > > > > Don't think we need "renderkit" in there, but I like the name change: > > > > > > org.apache.myfaces.trinidad.ENABLE_LIGHTWEIGHT_DIALOGS > > > > > > > > > > AND > > > > > > > > > > org.apache.myfaces.trinidadinternal.DISABLE_CONTENT_COMPRESSION > > > > becomes > > > > org.apache.myfaces.trinidad.DISABLE_CONTENT_COMPRESSION > > > > > > Maybe we should rename this? > > > > > > org.apache.myfaces.trinidad.DISABLE_STYLE_COMPRESSION > > > > > > -- Adam > > > > > > > > > > > Thanks, > > > > > > > > Danny > > > > -- > > > > Chordiant Software Inc. > > > > www.chordiant.com > > > > > > > > > > > -- > > > > Chordiant Software Inc. > > www.chordiant.com >
