UIComponentTag.setProperties() does not fully comply with JSF 1.1
-----------------------------------------------------------------
Key: MYFACES-1719
URL: https://issues.apache.org/jira/browse/MYFACES-1719
Project: MyFaces Core
Issue Type: Improvement
Components: JSR-127
Affects Versions: 1.1.4
Environment: Discovered under Tomcat 5.0 / Win XP SP2 / Sun JDK
1.5.0_09 / Cactus 1.7.2, but does not appear to be environment-specific.
Reporter: John Bollinger
Priority: Minor
The implementation of
javax.faces.webapp.UIComponentTag.setProperties(UIComponent) does not fully
comply with JSF 1.1 because it sets the renderer type of the class's
_componentInstance field instead of the method argument. On the other hand, it
sets the 'rendered' property of the argument as it should.
In normal use, the method argument and the field both reference the same
object, thus the class generally works as expected. The issue becomes a
problem, however, for unit tests of third-party tags: the setProperties()
methods of those tags cannot easily be tested directly because the
_componentInstance field is not initialized until doStartTag(), which invokes
setProperties() itself. In practice, some tests that run successfully against
the Sun reference implementation may fail against MyFaces because of this
issue. I haven't examined the MyFaces test suite, but I can only assume that
either its tag handlers' tests do not directly test this method at all, or they
rely on knowledge of the UIComponentTag implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
