[ 
https://issues.apache.org/jira/browse/TRINIDAD-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Lessard reopened TRINIDAD-130:
------------------------------------


Issues should be resolved, not closed. Also I found out that I missed some 
direct calls to SelectItemSupport.getSelectItems(component, converter); inside 
some renderers.

> Add non-final getSelectItems method to SimpleSelectOneRenderer
> --------------------------------------------------------------
>
>                 Key: TRINIDAD-130
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-130
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Components
>    Affects Versions: 1.0.1-core
>            Reporter: Simon Lessard
>            Assignee: Simon Lessard
>            Priority: Minor
>             Fix For: 1.0.2-core
>
>         Attachments: TRINIDAD-130.patch
>
>
> Currently, SimpleSelectOneRenderer get its list of SelectItem from 
> SelectItemSupport.getSelectItems(UIComponent, Converter) directly, not using 
> a protected method, effectively preventing that from being overridden.
> The use cases are very scarce, but it should be possible to get the LoV from 
> somewhere else without forcing the use of f:selectItems. Specifically, it's 
> the case when you want to generate a dynamic component (always looking 
> different) without altering the component tree (which is bad when done in the 
> render view phase and that would be the case here). Therefore, the following 
> non-final method should be added to SimpleSelectOneRenderer:
> protected List<SelectItem> getSelectItems(UIComponent component, Converter 
> converter)
> {
>   return SelectItemSupport.getSelectItems(component, converter);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to