I like the facets a lot too, but I'm not thrilled with adding
extra JS attributes when we already have a JS hook.
Two ways of doing things only makes sense when the second
is much easier, not just marginally easier.
-- Adam
On 9/12/07, Andrew Robinson <[EMAIL PROTECTED]> wrote:
>
> +1 great idea
>
> I would also like to suggest javascript support as well:
>
> <tr:statusIndicator onbusy="alert('starting ajax');"
> onready="alert('ajax done');" />
>
> This would probably be a simple hook around:
> TrPage.getInstance().getRequestQueue().addStateChangeListener(func);
>
> But it would be easier to have it on the component.
>
>
> On 9/12/07, Simon Lessard <[EMAIL PROTECTED]> wrote:
> > Hi all,
> >
> > I would like to add two facets to statusIndicator: "busy" and "ready",
> each
> > with an attached styleClass placed on a child span element. I think it
> would
> > make the component much more customizable as it would allow something
> like:
> >
> > <tr:statusIndicator>
> > <f:facet name="busy">
> > <tr:outputText value="Loading, please wait..."/>
> > </f:facet>
> > </tr:statusIndicator>
> >
> > and in the skin:
> >
> > af|statusIndicator::busy
> > {
> > border-color: black;
> > border-style: outset;
> > border-width: 2px;
> > display: block;
> > margin: auto;
> > position: absolute;
> > top: 45%;
> > text-align: center;
> > vertical-align: middle;
> > }
> >
> > af|statusIndicator::ready
> > {
> > }
> >
> > The icon would still be supported and placed in the parent span, at the
> same
> > place than now. The generated markup would thus look like:
> >
> > <span>
> > <span id="clientId::ready">
> > <img src="readyIcon"/>
> > <span class="af_statusIndicator_ready">
> > ("ready" facet content)
> > </span>
> > </span>
> > <span id="clientId::busy">
> > <img src="budyIcon"/>
> > <span class="af_statusIndicator_busy">
> > ("busy" facet content)
> > </span>
> > </span>
> > </span>
> >
> >
> > Anyone's ok with that or has a better idea?
> >
> > ~ Simon
> >
>