[ 
https://issues.apache.org/jira/browse/TRINIDAD-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528032
 ] 

Simon Lessard commented on TRINIDAD-712:
----------------------------------------

Hello both of you,

I slept over it last night and came to agree with Adam. If we remove the final, 
users will have the illusion that overriding the accessors is enough to hook 
all accesses to the attribute, and since it's not really the case, it's bad. 
However, I think we should provide an easier way to decorate retrieved 
properties. The only way I see is to override getFacesBean that isn't final. I 
think we should add a FacesBeanWrapper class to easily implement decorator 
pattern over FacesBean. Such strategy would give an easy hook to any property 
if users ever need one.

Sounds good?

p.s. JIRA is not the best place for such discussion, should we move it to dev 
list instead?

~ Simon

> Do not generate final properties with the maven-faces-plugin
> ------------------------------------------------------------
>
>                 Key: TRINIDAD-712
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-712
>             Project: MyFaces Trinidad
>          Issue Type: Wish
>          Components: Plugins
>    Affects Versions: 1.0.2-plugins
>         Environment: maven-faces-plugin version 1.0.2 from the maven 
> repository
>            Reporter: Andrew Robinson
>            Assignee: Adam Winer
>
> It would be extremely beneficial to not have property methods generated as 
> final by the maven-faces-plugin. 
> IMO, final should be reserved for constants and only on methods with rare 
> exceptions and good reasons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to