On 9/27/07, Jeanne Waldman <[EMAIL PROTECTED]> wrote:
>
>
>
> Cristi Toth wrote:
>
> Hi all,
>
> I've done some work on the tree renderer in Trinidad
> I added the connecting lines, like in Tomahawk (or any other tree) behind
> the expanded/collapsed icon (-, +)
> I now have 5 skin-selectors for the tree:
>
> af|tree::expanded-icon
> af|tree::collapsed-icon
> - these are the [-], [+] icons
>
> af|tree::line-icon - this one is the vertical line
> af|tree::line-middle-icon - this one is the horizontal line for each entry
> (used in the back of the expanded/collapsed icon)
> af|tree::line-last-icon - this one is like the one above, but it is used
> in the case of the last sibling (the corner)
>
> now some questions:
>
> 1) should I add a 'renderLines' attribute to the 'tree' component to
> enable/disable the lines ?
>
> I would make this a skin property, not a per instance component property.
> Something like:
> af|tree { -tr-render-lines: true}
>Sounds better indeed! 2) should I let the lines be skinnable and add them to the base skin? > > it's up to you. Showing/hiding them with the skin property probably is > enough. > So you think it's useless to make the lines skinnable? (sounds fine with me) 3) if I let them be skinnable, then should I ommit the 'renderLines' attr > and let the user just override the line icons with blank ones? > > again, I think this should be a skin property. > > > > Next, I worked on the TreeTable renderer. I made the 'Expand All / > Collapse All' links skinnable. > > 1. should I move the the 'Expand All / Collapse All' links on the first > row and get rid of the 2nd ? > It seems quite useless to have 2 rows > > not sure what you mean. > If you look in the screen-shot at the treeTable on the 2nd row there are the 'expand all/collapse all' links. I think they would fit perfectly on the first row (along the previous / next) and to get rid of the 2nd row (subControlBar) 2. should I also make the focus link 'X' skinnable (it looks kind of lame > right now) ? > > sure. I'm surprised it isn't already. > > > 3. should I add some attributes for disabling the focus column and the > breadCrumbs, for people who don't need them? > > 4. I noticed a bug in the row banding, it's not correctly rendered, I > suppose it would be nice if I fix it... > > You can see here a pictures with the results of what I did until now: > http://people.apache.org/~ckormos/tree_skinning.png<http://people.apache.org/%7Eckormos/tree_skinning.png> > > Is this welcomed by you guys? > > I like it. > > > regards, > -- > Cristi Toth > > ------------- > Codebeat > www.codebeat.ro > > Thanks for the feedback! -- Cristi Toth ------------- Codebeat www.codebeat.ro
