On Sat, 2007-10-06 at 17:41 +0200, Mario Ivankovits wrote: > [1] > http://people.apache.org/builds/myfaces/m2-staging-repository/org/apache/myfaces/orchestra/myfaces-orchestra-maven/1.0/ > [2] > http://people.apache.org/builds/myfaces/m2-staging-repository/org/apache/myfaces/orchestra/myfaces-orchestra-core/1.0/ >
I've checked the artifacts and have a few minor comments. The missing version data in the pom is worth fixing I think. The others are not particularly serious. Oh, and how can one easily check what JVM the class format is compatible with (ie verify that -target 1.4 was used)? ===== pom In the myfaces-core-1.0.pom, the following dependencies do not specify a version: * myfaces-api * myfaces-shared-orchestra * dependency-maven-plugin * build-helper-maven-plugin * rat-maven-plugin * jxr-maven-plugin * surefire-report-maven-plugin * maven-taglib-plugin * maven-javadoc-plugin * maven-source-plugin ===== core The MANIFEST.MF in core.jar seems a little short: Manifest-Version: 1.0 Archiver-Version: Plexus Archiver Created-By: Apache Maven Built-By: im Build-Jdk: 1.5.0_11 I can't find the docs about what exactly should go here, but I think the following should be there at least: * orchestra version * jvm target version (1.4) ===== core Minor question: is the name "spring-orchestra-init.xml" unique enough? Because we specify this as a resource, bad things will happen if there are more than one. An alternative would be "org.apache.myfaces.orchestra.spring-init.xml" or something similar. ==== javadoc Currently, package-private methods are being documented. Do we want this? It's good for developers but bad for users. I'm continuing to check the javadoc, and there are some minor fixes already. Nothing worth holding up a release for though. Regards, Simon
