Why would that make any difference? The classes are in two different
packages....
On Fri, 2007-10-19 at 14:29 -0500, Dennis Byrne wrote:
> (not sure if this issue has been covered yet in this thread)
>
> Because these classes are in shared, they will be "split" into two
> classes, one for core and one for tomahawk. When they are split, you
> will have two completely classes in the JVM who have the same serial
> id. I'm not going to say "don't do it", but I do think we can agree
> this is not a good idea?
>
> Dennis Byrne
>
> On 10/19/07, Simon Kitching <[EMAIL PROTECTED]> wrote:
> Hi All,
>
> I'd like to make a trivial commit to add serialVersionUID
> values to two classes in shared that don't yet have them. This
> avoids compile warnings in IDEs that have "warn on missing
> serialVersionUID" set.
>
> Adding the serialVersionUID is technically the right thing to
> do, IMO although in practice I agree it isn't terribly
> important for these particular classes.
>
> Any objections?
>
> Cheers,
>
> Simon
>
> Index:
> /home/sk/projects/apache/myfaces/shared/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java
> ===================================================================
> ---
> /home/sk/projects/apache/myfaces/shared/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java
> (revision 586396)
> +++
> /home/sk/projects/apache/myfaces/shared/core/src/main/java/org/apache/myfaces/shared/renderkit/RendererUtils.java
> (working copy)
> @@ -74,6 +74,7 @@
> public static final String SELECT_ITEM_LIST_ATTR =
> RendererUtils.class.getName () + ".LIST";
> public static final String EMPTY_STRING = "";
> public static final Object NOTHING = new Serializable() {
> + private static final long serialVersionUID =
> -8618356560493578754L;
> };
>
> public static final String ACTION_FOR_LIST =
> "org.apache.myfaces.ActionForList";
>
>
> Index:
> /home/sk/projects/apache/myfaces/shared/core/src/main/java/org/apache/myfaces/shared/util/servlet/SourceCodeServlet.java
>
> ===================================================================
> ---
> /home/sk/projects/apache/myfaces/shared/core/src/main/java/org/apache/myfaces/shared/util/servlet/SourceCodeServlet.java
> (revision 586396)
> +++
> /home/sk/projects/apache/myfaces/shared/core/src/main/java/org/apache/myfaces/shared/util/servlet/SourceCodeServlet.java
> (working copy)
> @@ -25,6 +25,8 @@
>
> public class SourceCodeServlet extends HttpServlet
> {
> + private static final long serialVersionUID =
> -2233965185519715475L;
> +
> public void doGet(HttpServletRequest req,
> HttpServletResponse res)
> throws IOException, ServletException
> {
>
>
>
>
> --
> Dennis Byrne
