no problem at all! You had fixed it anyways while I was offline ;) regards,
Martin On 10/25/07, Scott O'Bryan <[EMAIL PROTECTED]> wrote: > Argh... Yeah, I had a local svn repository to track my changes. When I > created the archive I thought I had removed all of those but I guess I > missed one. Sorry Martin. > > Scott > > Martin Marinschek wrote: > > Hi Scott, > > > > ok, I just committed the stuff from the zip-file again. I also noticed > > now why the original commit didn't take up this files: there was a > > .svn sub-directory in the zip-file, this must have tricked out > > subversion. Anyways, it's in. > > > > regards, > > > > Martin > > > > On 10/25/07, Scott O'Bryan <[EMAIL PROTECTED]> wrote: > > > >> Yeah, I code in the patch I submitted was from an older tree. I stuck > >> it in there to get the blocking bug fixed but I think it was code from > >> before my most recent code cleanup. I didn't check too closely because > >> I did not "functional" changes in my code cleanup. But the classes you > >> have probably look nicer and have the proper annotations... > >> > >> Scott > >> > >> Martin Marinschek wrote: > >> > >>> Ok, so you want me to commit the sources again I missed to commit > >>> > >> directly? > >> > >>> regards, > >>> > >>> Martin > >>> > >>> On 10/25/07, Scott O'Bryan <[EMAIL PROTECTED]> wrote: > >>> > >>> > >>>> :) I was confused. I think it WAS in zip file. Martin, can you do me > >>>> a favor and do a diff on the directory that was part of the initial > >>>> commit and the one I submitted to the bug. I think I did some cleanup > >>>> on the initial commit that was NOT present on my bug patch. Nothing > >>>> functional, but probably some formatting and @Override annotations... > >>>> > >>>> Martin Marinschek wrote: > >>>> > >>>> > >>>>> Hi Scott, > >>>>> > >>>>> no, it must have been my omission - cause the directory was there > >>>>> locally on my machine - I just missed it in the checkin. If you are > >>>>> telling me it wasn't there, then you're saying I extracted the wrong > >>>>> zip-file - I hope I didn't? > >>>>> > >>>>> regards, > >>>>> > >>>>> Martin > >>>>> > >>>>> On 10/25/07, Scott O'Bryan <[EMAIL PROTECTED]> wrote: > >>>>> > >>>>> > >>>>> > >>>>>> Ok Matthias, I included the missing code. It's a patch but it was > >>>>>> rather large so I had to zip it. Can you please commit it to the > >>>>>> > >> source > >> > >>>>>> tree. Sorry about the mixup. It was in the original code drop but > was > >>>>>> not, for some reason, in the revised code drop I sent down. > >>>>>> > >>>>>> Scott > >>>>>> > >>>>>> Matthias Weßendorf (JIRA) wrote: > >>>>>> > >>>>>> > >>>>>> > >>>>>>> BridgeRenderRequestWrapper.java file is missing > >>>>>>> ----------------------------------------------- > >>>>>>> > >>>>>>> Key: PORTLETBRIDGE-9 > >>>>>>> URL: > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>> https://issues.apache.org/jira/browse/PORTLETBRIDGE-9 > >>>>>> > >>>>>> > >>>>>> > >>>>>>> Project: MyFaces Portlet Bridge > >>>>>>> Issue Type: Bug > >>>>>>> Reporter: Matthias Weßendorf > >>>>>>> Assignee: Scott O'Bryan > >>>>>>> Priority: Blocker > >>>>>>> > >>>>>>> > >>>>>>> BridgeRenderRequestWrapper.java > >>>>>>> > >>>>>>> in pack. "org.apache.myfaces.portlet.faces.bridge.wrapper" is > missing. > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> > >>>>> > >>> > >>> > >> > > > > > > > > -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
