Hi!
1. Clear separation of API and IMPL (at least on package level, better
by separate artifacts).  Mind that the idea behind these commons
classes is that many other projects use them - and therefore depend on
them. So a clear and stable API is essential.
I wanted this to be an easy utils project and not yet-another-framework. In fact, there might be stuff in there which has an API and an IMPL, but this is not necessarily required. Static utils classes wont have an API. Shouldn't it be possible to have a stable API even without separating it out?

2. Let's start to name svn folders the same as the artifacts. This
seems to be best practice in many other maven projects. And there are
good reasons to do this.
So, the new project should be located in a folder named like
"myfaces-commons" with two sub folders "myfaces-commons-api" and
"myfaces-commons-impl".
I don't like that but wouldn't veto if we think this should be done that way, just, remember how this would look like:

/home/im/projects/myfaces12/commons/myfaces-commons/myfaces-commons-api/src/main/java
/home/im/projects/myfaces12/commons/myfaces-commons/myfaces-commons-impl/src/main/java

I think the middle part is overly redundant.

Ciao,
Mario

Reply via email to