[
https://issues.apache.org/jira/browse/TRINIDAD-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeanne Waldman updated TRINIDAD-804:
------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.2.3-core)
Assignee: Jeanne Waldman
Status: Resolved (was: Patch Available)
Checked into 1.2.4-branch before it was officially released.
Committed for Kamran.
> Unnecessary call to get/setRowKey in addPartialTarget
> -----------------------------------------------------
>
> Key: TRINIDAD-804
> URL: https://issues.apache.org/jira/browse/TRINIDAD-804
> Project: MyFaces Trinidad
> Issue Type: Bug
> Affects Versions: 1.2.3-core
> Environment: All (Tested on Windows XP SP2)
> Reporter: Kamran Kashanian
> Assignee: Jeanne Waldman
> Attachments: trinidad-1.2.3.ppr-target.patch
>
>
> The addPartialTarget method of the
> org.apache.myfaces.trinidadinternal.context.RequestContextImpl class contains
> some UIXCollection - specific code which, according to the comments in the
> code by AWiner, is no longer necessary in JSF 1.2.
> Specifically, before calling getClientId on the UIXCollection component, the
> code sets the "current" row key for the UIXCollection to null. In JSF 1.1,
> this was necessary to ensure a correct client id (with no row keys attached).
> With the addition of invokeOnComponent, in JSF 1.2, this call is no longer
> necessary, as the UIXCollection getClientId no longer attaches currency
> (instead see getContainerClientId).
> The issue with calling get/setRowKey in addPartialTarget is that it can cause
> an unnecessary invocation of the value binding for UIXCollection
> (table/treeTable, etc). For table and tree, the value binding call can be
> expensive.
> Attached is a patch which removes the call to get/setRowKey in
> addPartialTarget. Please note the comments by the original author in the
> original code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
