Hi, Yes you're right, sorry about that; before, text icons were supported, and the patch introduced image icons, and the tests weren't patched yet. If nobody has any objections, we'll update the tests also, asap, to test for img instead of span in the ouput.
regards, Catalin On Nov 14, 2007 11:33 PM, Andrew Robinson <[EMAIL PROTECTED]> wrote: > The current trunk (1.0.5) is broken in SVN with the golden files test > failing for the treeTable. Looks like img tags are now being used > instead of span elements. > > I think it was revision 595029 that broke it: > > r595029 | ckormos | 2007-11-14 13:14:19 -0700 (Wed, 14 Nov 2007) | 1 line > Changed paths: > M /myfaces/trinidad/trunk/trinidad/src/site/xdoc/skin-selectors.xml > M > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/java/org/apache/myfaces/trinidaddemo/DemoTreeData.java > M > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/java/org/apache/myfaces/trinidaddemo/InfiniteTree.java > M > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/java/org/apache/myfaces/trinidaddemo/TreeNodeImpl.java > M > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/demos/panelPageSkinDemo.jspx > M > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/beach/beach.css > A > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/beach/images/document.png > A > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/beach/images/yellow- > folder-closed.png > A > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/beach/images/yellow- > folder-open.png > M > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/purple/purpleSkin.css > M > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/desktop/TreeTableRenderer.java > M > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/skin/BaseDesktopSkin.java > M > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinProperties.java > M > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinSelectors.java > M > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/TreeRenderer.java > M > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/TreeNodeColumnRenderer.java > A > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/nav- > minus.gif > A > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/nav- > plus.gif > A > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/tree- > line-last.gif > A > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/tree- > line-middle.gif > A > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/tree- > line-trunk.gif > > fix for TRINIDAD-769 Tree / TreeTable skinning improvements (thanks to > Cristi Toth for provinding the patch). > ------------------------------------------------------------------------ >
