Cool thanks Simon. I'll take a look. :) Simon Lessard (JIRA) wrote:
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]Simon Lessard updated PORTLETBRIDGE-6: -------------------------------------- Attachment: PORTLETBRIDGE-6.patch Hi Scott, please review this patch because it's quite big and I don't want to commit it without peer review.JDK 1.5 Functionality --------------------- Key: PORTLETBRIDGE-6 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-6 Project: MyFaces Portlet Bridge Issue Type: Improvement Components: General Affects Versions: 1.0.0-SNAPSHOT Reporter: Scott O'Bryan Assignee: Simon Lessard Attachments: PORTLETBRIDGE-6.patch The bridge was originally coded to the JDK1.4 standard. Since JSF1.2 requires JDK5, we should follow the JDK5 standards for speed and reliability. Most notibly: * Specify generics wherever possible - especially in the ExternalContext implementations which use this by default * Remove the SimpleStringBuilder class in impl and replace it's usage with StringBuilder
