+1 for me as well, thanks for the patch :) On Nov 29, 2007 2:20 AM, Matthias Wessendorf <[EMAIL PROTECTED]> wrote:
> I revert my -1; since I replaced the broken plugins release. > > So, here is my +1 > > -M > > On Nov 29, 2007 8:41 AM, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > coool, will check that all. > > > > > > On Nov 29, 2007 1:11 AM, Gary Kind <[EMAIL PROTECTED]> wrote: > > > Done. > > > > > > > > > Scott O'Bryan wrote: > > > > Actually Gary, I think 808 is already committed, so the smaller > patch > > > > which just fixes 843 might be easier to apply. If this can't be > done, > > > > the patch may have to do. But if it can I think it would be > preferable. > > > > > > > > Scott > > > > > > > > Gary Kind wrote: > > > >> I have uploaded a new patch to Trinidad-808 with the fix for > > > >> Trinidad-843. > > > >> > > > >> Gary Kind wrote: > > > >>> Matthias, I have a fix for the NPE, should I make a complete > > > >>> trunk.patch again and put it on Trinidad-808? > > > >>> > > > >>> > > > >>> Matthias Wessendorf wrote: > > > >>>> -1 on this release, because of the 843 issue. > > > >>>> let me check it tomorrow morning. > > > >>>> > > > >>>> > > > >>>> On Nov 28, 2007 10:55 PM, Matthias Wessendorf <[EMAIL PROTECTED]> > > > >>>> wrote: > > > >>>> > > > >>>>> yes, just noticed that bug... > > > >>>>> fix you have a fix, I can replace the JARs tomorrow :-) > > > >>>>> > > > >>>>> > > > >>>>> On Nov 28, 2007 10:53 PM, Matt Cooper <[EMAIL PROTECTED]> > wrote: > > > >>>>> > > > >>>>>> Perhaps this release should wait on a fix for: > > > >>>>>> https://issues.apache.org/jira/browse/TRINIDAD-843 > > > >>>>>> > > > >>>>>> > > > >>>>>> > > > >>>>>> On Nov 28, 2007 8:29 AM, Matt Cooper < [EMAIL PROTECTED]> > wrote: > > > >>>>>> > > > >>>>>>> +1 > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> > > > >>>>>>> On Nov 27, 2007 1:47 PM, Gary Kind <[EMAIL PROTECTED]> > wrote: > > > >>>>>>> > > > >>>>>>> > > > >>>>>>>> +1 > > > >>>>>>>> > > > >>>>>>>> > > > >>>>>>>> > > > >>>>>>>> > > > >>>>>>>> Jeanne Waldman wrote: > > > >>>>>>>> > > > >>>>>>>>> +1 > > > >>>>>>>>> > > > >>>>>>>>> Gabrielle Crawford wrote: > > > >>>>>>>>> > > > >>>>>>>>>> +1 > > > >>>>>>>>>> > > > >>>>>>>>>> Bruno Aranda wrote: > > > >>>>>>>>>> > > > >>>>>>>>>>> +1 > > > >>>>>>>>>>> > > > >>>>>>>>>>> On 27/11/2007, Matthias Wessendorf < [EMAIL PROTECTED]> > wrote: > > > >>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>>> +1 > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> On Nov 27, 2007 10:26 AM, Matthias Wessendorf < > > > >>>>>>>>>>>> [EMAIL PROTECTED]> > > > >>>>>>>>>>>> wrote: > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>>>> Hi, > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> I was running the needed tasks to get the 1.2.5 release > of > > > >>>>>>>>>>>>> the > > > >>>>>>>>>>>>> > > > >>>>>> Apache > > > >>>>>> > > > >>>>>>>>>>>>> MyFaces Trinidad Maven 2 Plugins out. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> The artifacts are deployed to my private Apache account > > > >>>>>>>>>>>>> ([1]). > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> Please take a look at the " 1.2.5" artifacts and vote. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> How to test those JARs ? > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> 1. there is now a zip file (org.zip) (see [1]) > > > >>>>>>>>>>>>> 2. use the stage repo inside your pom.xml file: > > > >>>>>>>>>>>>> ... > > > >>>>>>>>>>>>> <pluginRepositories> > > > >>>>>>>>>>>>> <pluginRepository> > > > >>>>>>>>>>>>> <id>apache.stage</id> > > > >>>>>>>>>>>>> <name>Apache Stage Repository</name> > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> <url>http://people.apache.org/~matzew/125-plugins<http://people.apache.org/%7Ematzew/125-plugins> > </url> > > > >>>>>>>>>>>>> <layout>default</layout> > > > >>>>>>>>>>>>> </pluginRepository> > > > >>>>>>>>>>>>> </pluginRepositories> > > > >>>>>>>>>>>>> ... > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> ------------------------------------------------ > > > >>>>>>>>>>>>> [ ] +1 for community members who have reviewed and > tested > > > >>>>>>>>>>>>> the bits > > > >>>>>>>>>>>>> [ ] +0 > > > >>>>>>>>>>>>> [ ] -1 for fatal flaws that should cause these bits not > to be > > > >>>>>>>>>>>>> released, > > > >>>>>>>>>>>>> and why.............. > > > >>>>>>>>>>>>> ------------------------------------------------ > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> Thanks, > > > >>>>>>>>>>>>> Matthias > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> [1] > > > >>>>>>>>>>>>> http://people.apache.org/~matzew/125-plugins<http://people.apache.org/%7Ematzew/125-plugins> > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> -- > > > >>>>>>>>>>>>> Matthias Wessendorf > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> further stuff: > > > >>>>>>>>>>>>> blog: http://matthiaswessendorf.wordpress.com/ > > > >>>>>>>>>>>>> sessions: http://www.slideshare.net/mwessendorf > > > >>>>>>>>>>>>> mail: matzew-at-apache-dot-org > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>> -- > > > >>>>>>>>>>>> Matthias Wessendorf > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> further stuff: > > > >>>>>>>>>>>> blog: http://matthiaswessendorf.wordpress.com/ > > > >>>>>>>>>>>> sessions: http://www.slideshare.net/mwessendorf > > > >>>>>>>>>>>> mail: matzew-at-apache-dot-org > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>> > > > >>>>>> > > > >>>>> -- > > > >>>>> > > > >>>>> Matthias Wessendorf > > > >>>>> > > > >>>>> further stuff: > > > >>>>> blog: http://matthiaswessendorf.wordpress.com/ > > > >>>>> sessions: http://www.slideshare.net/mwessendorf > > > >>>>> mail: matzew-at-apache-dot-org > > > >>>>> > > > >>>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > > > > > > > > > > > > > -- > > Matthias Wessendorf > > > > further stuff: > > blog: http://matthiaswessendorf.wordpress.com/ > > sessions: http://www.slideshare.net/mwessendorf > > mail: matzew-at-apache-dot-org > > > > > > -- > Matthias Wessendorf > > further stuff: > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > mail: matzew-at-apache-dot-org >
