Hi Bernd,
is the SuppressWarnings("unchecked") Annotation really needed for checkstyle?
I don't like to annotate the complete method because of just one statement.
Regards,
Volker
2007/12/6, [EMAIL PROTECTED] <[EMAIL PROTECTED]>:
> Author: bommel
> Date: Thu Dec 6 14:41:18 2007
> New Revision: 601889
>
> URL: http://svn.apache.org/viewvc?rev=601889&view=rev
> Log:
> checkstyle
>
> Modified:
>
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/util/DebugPhaseListener.java
>
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/validator/FileItemValidator.java
>
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java
>
> Modified:
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/util/DebugPhaseListener.java
> URL:
> http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/util/DebugPhaseListener.java?rev=601889&r1=601888&r2=601889&view=diff
> ==============================================================================
> ---
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/util/DebugPhaseListener.java
> (original)
> +++
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/util/DebugPhaseListener.java
> Thu Dec 6 14:41:18 2007
> @@ -39,6 +39,7 @@
> private static final Log LOG = LogFactory.getLog(DebugPhaseListener.class);
> private static final String KEY = DebugPhaseListener.class.getName() +
> "_ID_";
>
> + @SuppressWarnings("unchecked")
> public void afterPhase(PhaseEvent phaseEvent) {
> if (LOG.isInfoEnabled()) {
> Date end = new Date();
> @@ -73,13 +74,13 @@
> LOG.info(MessageFormat.format("Faces message found."
> + "\n Component: {0} \n Severity : {1}"
> + "\n Summary : {2} \n Detail : {3}",
> - new Object[]{clientId, msg.getSeverity(),
> - msg.getSummary(), msg.getDetail()}));
> + new Object[]{clientId, msg.getSeverity(), msg.getSummary(),
> msg.getDetail()}));
> }
> }
> }
> }
>
> + @SuppressWarnings("unchecked")
> public void beforePhase(PhaseEvent phaseEvent) {
> if (LOG.isInfoEnabled()) {
> Date start = null;
>
> Modified:
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/validator/FileItemValidator.java
> URL:
> http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/validator/FileItemValidator.java?rev=601889&r1=601888&r2=601889&view=diff
> ==============================================================================
> ---
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/validator/FileItemValidator.java
> (original)
> +++
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/validator/FileItemValidator.java
> Thu Dec 6 14:41:18 2007
> @@ -44,7 +44,7 @@
> public static final String VALIDATOR_ID =
> "org.apache.myfaces.tobago.FileItem";
> public static final String SIZE_LIMIT_MESSAGE_ID =
> "org.apache.myfaces.tobago.FileItemValidator.SIZE_LIMIT";
> public static final String CONTENT_TYPE_MESSAGE_ID =
> "org.apache.myfaces.tobago.FileItemValidator.CONTENT_TYPE";
> - private Integer maxSize;
> + private Integer maxSize = null;
> private String contentType;
> private boolean transientValue;
>
>
> Modified:
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java
> URL:
> http://svn.apache.org/viewvc/myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java?rev=601889&r1=601888&r2=601889&view=diff
> ==============================================================================
> ---
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java
> (original)
> +++
> myfaces/tobago/trunk/core/src/main/java/org/apache/myfaces/tobago/webapp/TobagoResponseWriterImpl.java
> Thu Dec 6 14:41:18 2007
> @@ -80,6 +80,7 @@
> // LOG.info(" " + stackTrace[i].toString());
> // }
> this.writer = writer;
> + this.component = null;
> this.stack = new Stack<String>();
> this.contentType = contentType;
> this.characterEncoding
>
>
>
