[ 
https://issues.apache.org/jira/browse/MYFACES-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555288#action_12555288
 ] 

evert commented on MYFACES-1705:
--------------------------------

This issue is easy to fix.
just by adding the following line at the end of the encodeEnd method in 
HtmlButtonRendererBase:

writer.endElement(HTML.INPUT_ELEM);

I hope this fixed can be resolved soon.

> MyFaces 1.2.1 rendering of Tag <h:commandButton> inside <h:panelGrid> doesn't 
> close <td> tag
> --------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-1705
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1705
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 1.2.1-SNAPSHOT
>         Environment: Tomcat 6
> MyFaces 1.2.1
> JRE 1.6
>            Reporter: Andreas Gärtner
>            Priority: Minor
>
> Rendering of this page:
> <%@ page session="false" contentType="text/html;charset=utf-8"%>
> <%@ taglib uri="http://java.sun.com/jsf/html"; prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core"; prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tomahawk"; prefix="t"%>
> <html>
> <body>
> <f:view>
> <f:loadBundle basename="messages" var="messages" />
> <h:form id="form">
> <h:panelGrid columns="1">
> <h:commandButton value="Änderungen speichern" 
> action="#{persoenlicheDatenHandler.save}" />                    
> </h:panelGrid>
> </h:form>
> </f:view>
> </body>
> </html>
> comes out like this:
> <table><tbody><tr>
> <td>
> <input id="form:j_id_jsp_748720302_3" name="form:j_id_jsp_748720302_3" 
> type="submit" value="&Auml;nderungen speichern" onclick="if(typeof 
> window.clearFormHiddenParams_form=='function'){clearFormHiddenParams_form('form');}"
>  />
> </tr>
> </tbody></table>
> Results in the following warning:
> WARN HtmlResponseWriterImpl:234 - HTML nesting warning on closing td: element 
> input rendered by component : {Component-Path : [Class: 
> javax.faces.component.UIViewRoot,ViewId: /pages/daten.jsp][Class: 
> javax.faces.component.html.HtmlForm,Id: form][Class: 
> javax.faces.component.html.HtmlPanelGrid,Id: j_id_jsp_748720302_2][Class: 
> javax.faces.component.html.HtmlCommandButton,Id: j_id_jsp_748720302_3]} not 
> explicitly closed
> If changed to <h:panelGrid columns="2"> the output is:
> <table><tbody><tr><td>
> <input id="form:j_id_jsp_748720302_3" name="form:j_id_jsp_748720302_3" 
> type="submit" value="Änderungen speichern" onclick="if(typeof 
> window.clearFormHiddenParams_form=='function'){clearFormHiddenParams_form('form');}"
>  />
> <td></td></tr>
> </tbody></table>
> and therefore still one </td> short.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to