[
https://issues.apache.org/jira/browse/TOMAHAWK-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556383#action_12556383
]
Simon Kitching commented on TOMAHAWK-923:
-----------------------------------------
Hi Thomas. Yes, I agree that display:none is theoretically better than
visibility:hidden.
However I don't actually see any problems in practice. Can you provide a page
showing problems with the existing calendar implementation? If not, I am
reluctant to change anything as a change could potentially break IE5, IE6, IE7,
Firefox, Safari, or Opera. Retesting that lot is a pain, so changing this is
only worthwhile if a real problem can be shown.
By the way, the removal of _hideElement in the attached patch would break
Internet Explorer in some cases; I have added comments to file popcalendar.js
explaining why.
> The CSS Style for the Input Popup Calendar should be switched to 'display:
> none' instead of 'display: hidden'
> -------------------------------------------------------------------------------------------------------------
>
> Key: TOMAHAWK-923
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-923
> Project: MyFaces Tomahawk
> Issue Type: Improvement
> Components: Calendar
> Affects Versions: 1.1.5-SNAPSHOT
> Environment: WAS 6, Java 1.4
> Reporter: Thomas Hoppe
> Attachments: popcalendar.patch
>
>
> The t:inputCalendar component when rendered as a popup calendar uses the css
> attribute display: hidden
> to hide the popup. This is bad design as a hidden attribute occupies space
> even it is not shown in some cases.
> Therefore just switch to display: none to hide the popup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
