[ 
https://issues.apache.org/jira/browse/TOMAHAWK-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556391#action_12556391
 ] 

Simon Kitching commented on TOMAHAWK-787:
-----------------------------------------

oops .. for some reason, the comment above was submitted incomplete. Here's the 
rest:

            <t:inputCalendar id="secondOne" monthYearRowClass="yearMonthHeader" 
weekRowClass="weekHeader" popupButtonStyleClass="standard_bold"
                currentDayCellClass="currentDayCell" 
value="#{calendarBean.secondDate}" renderAsPopup="true"
                popupTodayString="#{example_messages['popup_today_string']}"
                popupDateFormat="MM/dd/yyyy hh:mm:ss a" 
popupWeekString="#{example_messages['popup_week_string']}"
                helpText="MM/DD/YYYY"
                forceId="true"/>

            <t:inputCalendar id="thirdOne" monthYearRowClass="yearMonthHeader" 
weekRowClass="weekHeader" popupButtonStyleClass="standard_bold"
                currentDayCellClass="currentDayCell" 
value="#{calendarBean.secondDate}" renderAsPopup="true"
                popupTodayString="#{example_messages['popup_today_string']}"
                popupDateFormat="MM/dd/yyyy HH:mm:ss" 
popupWeekString="#{example_messages['popup_week_string']}"
                helpText="MM/DD/YYYY"/>

Manually entering hours into the second field (24-hour time) causes the first 
field to correctly render 12-hour time.

Could you please retest with the latest Tomahawk snapshot from the apache 
snapshot repository here?
  
http://people.apache.org/repo/m2-snapshot-repository/org/apache/myfaces/tomahawk/tomahawk/1.1.7-SNAPSHOT/

> Incorrect display of 12-hour time in t:inputCalendar
> ----------------------------------------------------
>
>                 Key: TOMAHAWK-787
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-787
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Calendar
>    Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT
>            Reporter: Richard J. Barbalace
>
> If the date format attribute specifies 12-hour time, as in:
>     popupDateFormat="d MMM yyyy hh:mm:ss a"
> rather than 24-hour time, as in:
>     popupDateFormat="d MMM yyyy HH:mm:ss"
> then the display from the calendar still reports 24-hour time, yielding 
> something like this:
>     Today is 16 Nov 2006 16:23:04 AM
> That of course should read as:
>     Today is 16 Nov 2006 04:23:04 PM
> I suspect the bug involves the code beginning around line 344 of
>      
> core/src/main/resources/org/apache/myfaces/custom/calendar/resource/date.js
> which reads:
>         else if(patternSub.charAt(0)=='H' ||
>                 patternSub.charAt(0)=='h')
> There should probably be separate cases for 'H' and 'h', for which the latter 
> would subtract 12 from the context.hour, but I am not familiar enough with 
> this code to be sure.  There might also be an issue with the AM/PM setting 
> further down the file around line 381.
> There are, in case anyone wonders why the time should be set from a calendar 
> control, valid reasons for doing this, such as in my application where it is 
> desired to be able to correct the date on an incorrectly entered timestamp 
> from some other source.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to