[ 
https://issues.apache.org/jira/browse/ORCHESTRA-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557584#action_12557584
 ] 

Simon Kitching commented on ORCHESTRA-14:
-----------------------------------------

Sorry, just to be clear: the attributeRemove calls above are being triggered by 
a session timeout. I set the session timeout to 3 minutes, visited a few pages 
then waited. As expected, 3 minutes later there is a sequence of calls to 
attributeRemoved, one for each attribute in the session.

> ConversationManagerSessionListener leak & IllegalStateException
> ---------------------------------------------------------------
>
>                 Key: ORCHESTRA-14
>                 URL: https://issues.apache.org/jira/browse/ORCHESTRA-14
>             Project: MyFaces Orchestra
>          Issue Type: Bug
>          Components: Conversation
>    Affects Versions: 1.1
>         Environment: tomcat 5
>            Reporter: Thomas Spiegl
>            Assignee: Thomas Spiegl
>             Fix For: 1.1
>
>
> ConversationManagerSessionListener has serveral issues:
> 1) attributeReplaced sets the old instance of conversationManager in 
> conversationWiperThread instead of the new one
> 2) on session expire ConversationManagerSessionListener.attributeRemoved is 
> getting called and session.getId() throws IllegalStateException
> 3) ConversationManagerSessionListener.sessionDestroyed will throw a 
> IllegalStateException as well -> method is useless
> Solution:
> 1) use a unique id for conversationManager instead of session.getId() as a 
> key in conversationWiperThread
> 2) remove HttpSessionListener interface from 
> ConversationManagerSessionListener

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to