On Jan 22, 2008 7:23 PM, simon <[EMAIL PROTECTED]> wrote: > > On Tue, 2008-01-22 at 12:50 -0300, Leonardo Uribe wrote: > > Hi, > > > > I was running the needed tasks to get the 1.2.2 release of Apache > > MyFaces core out. > > > > Please note that this vote concerns all of the following parts: > > 1. Maven artifact group "org.apache.myfaces.shared" v3.0.2 [1] > > 2. Maven artifact group "org.apache.myfaces.core" v1.2.2 [1] > > > > The artifacts are deployed to my private Apache account ([1]). > > > > Please take a look at the "1.2.2" artifacts and vote! > > > > Please note: This vote is "majority approval" with a minimum of three > > +1 votes (see [3]). > > > > ------------------------------------------------ > > [ ] +1 for community members who have reviewed the bits > > [ ] +0 > > [ ] -1 for fatal flaws that should cause these bits not to be released, > > and why.............. > > ------------------------------------------------ > > ==== important > > (1) > in the impl jar, file META-INF/standard-faces-config.xml has a few > component entries like this: > <property> > <description> > <p> > The URL of the image. If the URL starts with a '/', it > is relative > to the context path of the web application. > </p> > <p> > This attribute is an alias for the "value" property. > </p> > > </description> > <property-name>url</property-name> > <property-class>java.lang.String</property-class> > </property> > > Will this cause problems? I don't know what the "description" field in a > standard-faces-config file is used for..
no - it will at least not be used by MyFaces (2) > Can we please hava a CLIRR report to check for binary incompatibilities? > > See clirr.sourceforge.net > @Leonardo: if time permits, please do so... > > ==== less important > > (3) > Normally in commons, the following entries are also added to manifests: > x-java-source > X-java-target > so that it is clear which versions of java this is compatible with. > > Neither the shared, api nor impl jars have these entries. > > The bytecode version in the classes is 49, ie java5 which is fine. > hmm... it might have been better to build with 1.4, right? is it necessary for the release to go out? > (4) > The MANIFEST.MF file for the shared-core-sources has no version info at > all. we should fix that for the next release > (5) > The api jar has a strange META-INF/rsc subdirectory. yes, that is intended - it is for displaying the facelets-like error-page > > (6) > the impl jar has "myfaces_core.tld" but "myfaces-html.tld". we should fix that for the next release regards, Martin
